Skip to content

numpy: asan - #50

Closed
lucascolley wants to merge 1 commit into
rgommers:mainfrom
lucascolley:asan
Closed

lucascolley wants to merge 1 commit into
rgommers:mainfrom
lucascolley:asan

Conversation

@lucascolley

Copy link
Copy Markdown
Contributor

No description provided.

file: build.sh
env:
MINOR_VERSION: "3.13"
PYTHON_ASAN: "1"

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the proper way to do this is with a multi-output recipe, then we can depend on e.g. either python or python-asan

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not so sure about that. I think multi-output recipes are when you want multiple separate packages, rather than different build variants of the same package. Building multiple outputs would also be much slower, because they'd be full rebuilds of the whole package with different compiler flags.

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That might make sense, in a way it's similar to python-freethreading: the Python build has some property (say asan-build, it's not specific to python) that multiple packages should share, and can be installed in a synchronized fashion.

You may want to get some expert input on this one, I don't know if this is possible today with Pixi and if so what the best solution is.

It's also similar to the "build profiles" with debug/release variants.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed with everything you have said, and expert opinion has already been sought :). Indeed python-freethreading was what I was looking at when I wrote that.

I didn't jump to variants because it is currently not possible to select a variant of a local path dependency (e.g. via build_string) with pixi-build (we have an internal issue but should make a public one).

Once we have Wolf's flags CEP the real "proper" way to do this would probably look something like prefix-dev/pixi#2813 (comment).

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds great then!

@rgommers

Copy link
Copy Markdown
Owner

This would be very cool to get to work. 👍🏼 🚀

@lucascolley

Copy link
Copy Markdown
Contributor Author

Now done upstream

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants