Upgrade go-fuse (fixes #595: reverse mount on macOS)#690
Closed
valeriangalliat wants to merge 1 commit intorfjakob:masterfrom
valeriangalliat:upgrade-go-fuse
Closed
Upgrade go-fuse (fixes #595: reverse mount on macOS)#690valeriangalliat wants to merge 1 commit intorfjakob:masterfrom valeriangalliat:upgrade-go-fuse
valeriangalliat wants to merge 1 commit intorfjakob:masterfrom
valeriangalliat:upgrade-go-fuse
Conversation
rfjakob
requested changes
Oct 21, 2022
Owner
rfjakob
left a comment
rfjakob
left a comment
There was a problem hiding this comment.
Hi, thanks for the PR!
It's good, but could you update it with two things:
-
The PR description text is very good, but the commit message is a little short ;)
Use the PR description text as the commit message. -
go-fuse has had a new commit in the meantime, please use this latest version.
Ran `go get -u github.com/hanwen/go-fuse/v2@master` to get this diff As pointed out in #595 (comment), go-fuse was updated with a patch to allow `-reverse` mode on macOS!
Contributor
Author
|
Updated go-fuse to the latest |
Owner
|
Merged as 0ec7ffb , thanks! (you missed a "go mod tidy" to get rid of the old references, did that for you) |
Owner
|
For posterity: The commit on go-fuse that fixes this is hanwen/go-fuse@58a7e14 |
rfjakob
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ran
go get -u github.com/hanwen/go-fuse/v2@masterto get this diffAs pointed out in #595 (comment), go-fuse was updated with a patch to allow
-reversemode on macOS!