ci(sync): gate publish on full build + patched-package tests#54
Merged
Conversation
Run `go build ./...` plus tests over the patched packages before publishing a sync, and make the publish step depend on it via success(). A rebase can apply our patches cleanly yet break compilation when upstream changes a type we rely on (e.g. cli#13403 int64 IDs); the previous gate only ran ./internal/config and its custom `if` let publish run even on failure.
davidlovas
enabled auto-merge (squash)
June 22, 2026 07:13
rexovas-open-source Bot
added a commit
that referenced
this pull request
Jun 22, 2026
Run `go build ./...` plus tests over the patched packages before publishing a sync, and make the publish step depend on it via success(). A rebase can apply our patches cleanly yet break compilation when upstream changes a type we rely on (e.g. cli#13403 int64 IDs); the previous gate only ran ./internal/config and its custom `if` let publish run even on failure.
rexovas-open-source Bot
added a commit
that referenced
this pull request
Jun 23, 2026
Run `go build ./...` plus tests over the patched packages before publishing a sync, and make the publish step depend on it via success(). A rebase can apply our patches cleanly yet break compilation when upstream changes a type we rely on (e.g. cli#13403 int64 IDs); the previous gate only ran ./internal/config and its custom `if` let publish run even on failure.
rexovas-open-source Bot
added a commit
that referenced
this pull request
Jun 24, 2026
Run `go build ./...` plus tests over the patched packages before publishing a sync, and make the publish step depend on it via success(). A rebase can apply our patches cleanly yet break compilation when upstream changes a type we rely on (e.g. cli#13403 int64 IDs); the previous gate only ran ./internal/config and its custom `if` let publish run even on failure.
rexovas-open-source Bot
added a commit
that referenced
this pull request
Jun 24, 2026
Run `go build ./...` plus tests over the patched packages before publishing a sync, and make the publish step depend on it via success(). A rebase can apply our patches cleanly yet break compilation when upstream changes a type we rely on (e.g. cli#13403 int64 IDs); the previous gate only ran ./internal/config and its custom `if` let publish run even on failure.
rexovas-open-source Bot
added a commit
that referenced
this pull request
Jun 25, 2026
Run `go build ./...` plus tests over the patched packages before publishing a sync, and make the publish step depend on it via success(). A rebase can apply our patches cleanly yet break compilation when upstream changes a type we rely on (e.g. cli#13403 int64 IDs); the previous gate only ran ./internal/config and its custom `if` let publish run even on failure.
rexovas-open-source Bot
added a commit
that referenced
this pull request
Jun 25, 2026
Run `go build ./...` plus tests over the patched packages before publishing a sync, and make the publish step depend on it via success(). A rebase can apply our patches cleanly yet break compilation when upstream changes a type we rely on (e.g. cli#13403 int64 IDs); the previous gate only ran ./internal/config and its custom `if` let publish run even on failure.
rexovas-open-source Bot
added a commit
that referenced
this pull request
Jun 25, 2026
Run `go build ./...` plus tests over the patched packages before publishing a sync, and make the publish step depend on it via success(). A rebase can apply our patches cleanly yet break compilation when upstream changes a type we rely on (e.g. cli#13403 int64 IDs); the previous gate only ran ./internal/config and its custom `if` let publish run even on failure.
rexovas-open-source Bot
added a commit
that referenced
this pull request
Jun 29, 2026
Run `go build ./...` plus tests over the patched packages before publishing a sync, and make the publish step depend on it via success(). A rebase can apply our patches cleanly yet break compilation when upstream changes a type we rely on (e.g. cli#13403 int64 IDs); the previous gate only ran ./internal/config and its custom `if` let publish run even on failure.
rexovas-open-source Bot
added a commit
that referenced
this pull request
Jun 30, 2026
Run `go build ./...` plus tests over the patched packages before publishing a sync, and make the publish step depend on it via success(). A rebase can apply our patches cleanly yet break compilation when upstream changes a type we rely on (e.g. cli#13403 int64 IDs); the previous gate only ran ./internal/config and its custom `if` let publish run even on failure.
rexovas-open-source Bot
added a commit
that referenced
this pull request
Jul 1, 2026
Run `go build ./...` plus tests over the patched packages before publishing a sync, and make the publish step depend on it via success(). A rebase can apply our patches cleanly yet break compilation when upstream changes a type we rely on (e.g. cli#13403 int64 IDs); the previous gate only ran ./internal/config and its custom `if` let publish run even on failure.
rexovas-open-source Bot
added a commit
that referenced
this pull request
Jul 2, 2026
Run `go build ./...` plus tests over the patched packages before publishing a sync, and make the publish step depend on it via success(). A rebase can apply our patches cleanly yet break compilation when upstream changes a type we rely on (e.g. cli#13403 int64 IDs); the previous gate only ran ./internal/config and its custom `if` let publish run even on failure.
rexovas-open-source Bot
added a commit
that referenced
this pull request
Jul 2, 2026
Run `go build ./...` plus tests over the patched packages before publishing a sync, and make the publish step depend on it via success(). A rebase can apply our patches cleanly yet break compilation when upstream changes a type we rely on (e.g. cli#13403 int64 IDs); the previous gate only ran ./internal/config and its custom `if` let publish run even on failure.
rexovas-open-source Bot
added a commit
that referenced
this pull request
Jul 3, 2026
Run `go build ./...` plus tests over the patched packages before publishing a sync, and make the publish step depend on it via success(). A rebase can apply our patches cleanly yet break compilation when upstream changes a type we rely on (e.g. cli#13403 int64 IDs); the previous gate only ran ./internal/config and its custom `if` let publish run even on failure.
rexovas-open-source Bot
added a commit
that referenced
this pull request
Jul 3, 2026
Run `go build ./...` plus tests over the patched packages before publishing a sync, and make the publish step depend on it via success(). A rebase can apply our patches cleanly yet break compilation when upstream changes a type we rely on (e.g. cli#13403 int64 IDs); the previous gate only ran ./internal/config and its custom `if` let publish run even on failure.
rexovas-open-source Bot
added a commit
that referenced
this pull request
Jul 8, 2026
Run `go build ./...` plus tests over the patched packages before publishing a sync, and make the publish step depend on it via success(). A rebase can apply our patches cleanly yet break compilation when upstream changes a type we rely on (e.g. cli#13403 int64 IDs); the previous gate only ran ./internal/config and its custom `if` let publish run even on failure.
rexovas-open-source Bot
added a commit
that referenced
this pull request
Jul 9, 2026
Run `go build ./...` plus tests over the patched packages before publishing a sync, and make the publish step depend on it via success(). A rebase can apply our patches cleanly yet break compilation when upstream changes a type we rely on (e.g. cli#13403 int64 IDs); the previous gate only ran ./internal/config and its custom `if` let publish run even on failure.
rexovas-open-source Bot
added a commit
that referenced
this pull request
Jul 9, 2026
Run `go build ./...` plus tests over the patched packages before publishing a sync, and make the publish step depend on it via success(). A rebase can apply our patches cleanly yet break compilation when upstream changes a type we rely on (e.g. cli#13403 int64 IDs); the previous gate only ran ./internal/config and its custom `if` let publish run even on failure.
rexovas-open-source Bot
added a commit
that referenced
this pull request
Jul 10, 2026
Run `go build ./...` plus tests over the patched packages before publishing a sync, and make the publish step depend on it via success(). A rebase can apply our patches cleanly yet break compilation when upstream changes a type we rely on (e.g. cli#13403 int64 IDs); the previous gate only ran ./internal/config and its custom `if` let publish run even on failure.
rexovas-open-source Bot
added a commit
that referenced
this pull request
Jul 13, 2026
Run `go build ./...` plus tests over the patched packages before publishing a sync, and make the publish step depend on it via success(). A rebase can apply our patches cleanly yet break compilation when upstream changes a type we rely on (e.g. cli#13403 int64 IDs); the previous gate only ran ./internal/config and its custom `if` let publish run even on failure.
rexovas-open-source Bot
added a commit
that referenced
this pull request
Jul 13, 2026
Run `go build ./...` plus tests over the patched packages before publishing a sync, and make the publish step depend on it via success(). A rebase can apply our patches cleanly yet break compilation when upstream changes a type we rely on (e.g. cli#13403 int64 IDs); the previous gate only ran ./internal/config and its custom `if` let publish run even on failure.
rexovas-open-source Bot
added a commit
that referenced
this pull request
Jul 16, 2026
Run `go build ./...` plus tests over the patched packages before publishing a sync, and make the publish step depend on it via success(). A rebase can apply our patches cleanly yet break compilation when upstream changes a type we rely on (e.g. cli#13403 int64 IDs); the previous gate only ran ./internal/config and its custom `if` let publish run even on failure.
rexovas-open-source Bot
added a commit
that referenced
this pull request
Jul 20, 2026
Run `go build ./...` plus tests over the patched packages before publishing a sync, and make the publish step depend on it via success(). A rebase can apply our patches cleanly yet break compilation when upstream changes a type we rely on (e.g. cli#13403 int64 IDs); the previous gate only ran ./internal/config and its custom `if` let publish run even on failure.
rexovas-open-source Bot
added a commit
that referenced
this pull request
Jul 20, 2026
Run `go build ./...` plus tests over the patched packages before publishing a sync, and make the publish step depend on it via success(). A rebase can apply our patches cleanly yet break compilation when upstream changes a type we rely on (e.g. cli#13403 int64 IDs); the previous gate only ran ./internal/config and its custom `if` let publish run even on failure.
rexovas-open-source Bot
added a commit
that referenced
this pull request
Jul 21, 2026
Run `go build ./...` plus tests over the patched packages before publishing a sync, and make the publish step depend on it via success(). A rebase can apply our patches cleanly yet break compilation when upstream changes a type we rely on (e.g. cli#13403 int64 IDs); the previous gate only ran ./internal/config and its custom `if` let publish run even on failure.
rexovas-open-source Bot
added a commit
that referenced
this pull request
Jul 21, 2026
Run `go build ./...` plus tests over the patched packages before publishing a sync, and make the publish step depend on it via success(). A rebase can apply our patches cleanly yet break compilation when upstream changes a type we rely on (e.g. cli#13403 int64 IDs); the previous gate only ran ./internal/config and its custom `if` let publish run even on failure.
rexovas-open-source Bot
added a commit
that referenced
this pull request
Jul 22, 2026
Run `go build ./...` plus tests over the patched packages before publishing a sync, and make the publish step depend on it via success(). A rebase can apply our patches cleanly yet break compilation when upstream changes a type we rely on (e.g. cli#13403 int64 IDs); the previous gate only ran ./internal/config and its custom `if` let publish run even on failure.
rexovas-open-source Bot
added a commit
that referenced
this pull request
Jul 22, 2026
Run `go build ./...` plus tests over the patched packages before publishing a sync, and make the publish step depend on it via success(). A rebase can apply our patches cleanly yet break compilation when upstream changes a type we rely on (e.g. cli#13403 int64 IDs); the previous gate only ran ./internal/config and its custom `if` let publish run even on failure.
rexovas-open-source Bot
added a commit
that referenced
this pull request
Jul 22, 2026
Run `go build ./...` plus tests over the patched packages before publishing a sync, and make the publish step depend on it via success(). A rebase can apply our patches cleanly yet break compilation when upstream changes a type we rely on (e.g. cli#13403 int64 IDs); the previous gate only ran ./internal/config and its custom `if` let publish run even on failure.
rexovas-open-source Bot
added a commit
that referenced
this pull request
Jul 22, 2026
Run `go build ./...` plus tests over the patched packages before publishing a sync, and make the publish step depend on it via success(). A rebase can apply our patches cleanly yet break compilation when upstream changes a type we rely on (e.g. cli#13403 int64 IDs); the previous gate only ran ./internal/config and its custom `if` let publish run even on failure.
rexovas-open-source Bot
added a commit
that referenced
this pull request
Jul 22, 2026
Run `go build ./...` plus tests over the patched packages before publishing a sync, and make the publish step depend on it via success(). A rebase can apply our patches cleanly yet break compilation when upstream changes a type we rely on (e.g. cli#13403 int64 IDs); the previous gate only ran ./internal/config and its custom `if` let publish run even on failure.
rexovas-open-source Bot
added a commit
that referenced
this pull request
Jul 22, 2026
Run `go build ./...` plus tests over the patched packages before publishing a sync, and make the publish step depend on it via success(). A rebase can apply our patches cleanly yet break compilation when upstream changes a type we rely on (e.g. cli#13403 int64 IDs); the previous gate only ran ./internal/config and its custom `if` let publish run even on failure.
rexovas-open-source Bot
added a commit
that referenced
this pull request
Jul 23, 2026
Run `go build ./...` plus tests over the patched packages before publishing a sync, and make the publish step depend on it via success(). A rebase can apply our patches cleanly yet break compilation when upstream changes a type we rely on (e.g. cli#13403 int64 IDs); the previous gate only ran ./internal/config and its custom `if` let publish run even on failure.
rexovas-open-source Bot
added a commit
that referenced
this pull request
Jul 24, 2026
Run `go build ./...` plus tests over the patched packages before publishing a sync, and make the publish step depend on it via success(). A rebase can apply our patches cleanly yet break compilation when upstream changes a type we rely on (e.g. cli#13403 int64 IDs); the previous gate only ran ./internal/config and its custom `if` let publish run even on failure.
rexovas-open-source Bot
added a commit
that referenced
this pull request
Jul 24, 2026
Run `go build ./...` plus tests over the patched packages before publishing a sync, and make the publish step depend on it via success(). A rebase can apply our patches cleanly yet break compilation when upstream changes a type we rely on (e.g. cli#13403 int64 IDs); the previous gate only ran ./internal/config and its custom `if` let publish run even on failure.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Makes the upstream-sync workflow actually gate publishing on a real build + tests.
Before: the sync ran
go test ./internal/config/...only, and the publish step'sif: steps.rebase.outputs.status == 'success'(a customif, which replaces the defaultsuccess()check) ran even if that test step failed. So a rebase that applied our patches cleanly but broke compilation elsewhere (e.g. cli#13403 switching IDs toint64, which brokepkg/cmd/ruleset) shipped anyway.After:
go build ./...(catches compile breakage anywhere) plusgo testover the patched packages (config, gh, auth, ruleset, version).steps.rebase.outputs.status == 'success' && success(), so any build/test failure skips the publish and leaves trunk at the last good state.CI-only.