Skip to content

Comments

Add Japanese & Traditional Chinese translations#43

Merged
reveny merged 44 commits intoreveny:mainfrom
kxob:main
Mar 5, 2025
Merged

Add Japanese & Traditional Chinese translations#43
reveny merged 44 commits intoreveny:mainfrom
kxob:main

Conversation

@kxob
Copy link
Contributor

@kxob kxob commented Feb 27, 2025 •
edited
Loading

Traditional Chinese translations are based on Simplified Chinese strings.

kxob added 30 commits February 12, 2025 22:29
@kxob
Update Simplified Chinese strings.xml
8244ca2
@kxob
Replace two hardcoded strings in MainViewModel.kt
a74c2a7
@kxob
Replace hardcoded strings in Settings.kt
316ea61
@kxob
Replace hardcoded strings in App.kt
cb89495
@kxob
Replace hardcoded strings in Appearance.kt
adb4698
@kxob
Update strings.xml
34a2429
@kxob
Complete Simplified Chinese strings.xml
9c0c89b
@kxob
Sync the latest label for Settings.kt
e0efeb4
@kxob
Replace hardcoded strings in CardItem.kt
1f0528b
@kxob
Update strings.xml
18a4781
@kxob
Complete Simplified Chinese translations
c434960
@kxob
Fix build issue of MainViewModel.kt
7caa5cb
@kxob
Update Language.kt to make it accept title parameter
c205089
@kxob
Revert an unnecessary call in App.kt
fe11aea
@kxob
Make the string “Language” localizable
fb5f03a
@kxob
Correct mistakes in MainViewModel.kt
c60af6c
@kxob
Make experimental detection status localizable
2301426
@kxob
Add hints to distinguished true/false value in strings.xml
98305fe 
for more accurate translations.
@kxob
Make version_is_available string translatable
87c99e5
@kxob
Translate Simplified Chinese version_is_available string
8211d0e
@kxob
Make language strings translatable
4e0f8c5
@kxob
Delete strings_untranslatable.xml since there's only one string unt…
dfbea3b 
…ranslatable

And the only one is moved to `strings.xml`
@kxob
Translate language strings for Simplified Chinese
c10d852
@kxob
Add Spanish & Indonesian in strings.xml
8d26fd8
@kxob
Add Spanish & Indonesian in Simplified Chinese strings.xml
bdf7b91
@kxob
Squashed commit of the following:
c9d2c86 
commit 4aac0a3
Author: Beni Fachrudin <[email protected]>
Date:   Thu Feb 13 20:25:09 2025 +0700

    Added several list of {spanish|indonesian} languages (reveny#37)

    Subsequent to:
    * 4f95216.
    * 6251176.
    * c7e81c7.

    Change-Id: I6bccd07ce2705a8fb3b2771cdbde83aac842677d

    Signed-off-by: Neebe3289 <[email protected]>
@kxob
Merge remote-tracking branch 'upstream/main'
3e84723
@kxob
Update Simplified Chinese strings.xml
ed82902
@kxob
Add Traditional Chinese
5b21cb1
@kxob
Add zh_tw into strings.xml
547517b
@VisionR1 VisionR1 mentioned this pull request Feb 27, 2025
Merged
@kxob
Copy link
Contributor Author

kxob commented Feb 28, 2025

I will add Japanese soon.

@kxob kxob changed the title Add Traditional Chinese translations Add Japanese & Traditional Chinese translations Mar 1, 2025
@kxob
Copy link
Contributor Author

kxob commented Mar 1, 2025

@reveny OK, you can merge it.

@Neebe3289
Copy link
Contributor

Neebe3289 commented Mar 3, 2025

maybe in another time you do harcoded all strings to follow new UI, i mean for other language 😁 @kxob

@VisionR1
Copy link
Contributor

VisionR1 commented Mar 3, 2025

maybe in another time you do harcoded all strings to follow new UI, i mean for other language 😁 @kxob

Hardcoded ? I think now is localizable. 🤔

@Neebe3289
Copy link
Contributor

Neebe3289 commented Mar 3, 2025

maybe in another time you do harcoded all strings to follow new UI, i mean for other language 😁 @kxob

Hardcoded ? I think now is localizable. 🤔

oh yea forgot lol 😁

@VisionR1
Copy link
Contributor

VisionR1 commented Mar 3, 2025

maybe in another time you do harcoded all strings to follow new UI, i mean for other language 😁 @kxob

Hardcoded ? I think now is localizable. 🤔

oh yea forgot lol 😁

Now me and @kxob we waiting @reveny to merged our PR.
I have add Greek Language: #40

@reveny reveny merged commit 1ac32c2 into reveny:main Mar 5, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@VisionR1 VisionR1 VisionR1 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@kxob @Neebe3289 @VisionR1 @reveny