Skip to content

Comments

Add Greek translation#40

Merged
reveny merged 9 commits intoreveny:mainfrom
VisionR1:main
Mar 5, 2025
Merged

Add Greek translation#40
reveny merged 9 commits intoreveny:mainfrom
VisionR1:main

Conversation

@VisionR1
Copy link
Contributor

Full Greek Translation, but some still don't appear, inside in the app, until merged this: #36

@kxob
Copy link
Contributor

kxob commented Feb 27, 2025

Language strings can also be translated since 4e0f8c5

@VisionR1
Copy link
Contributor Author

VisionR1 commented Feb 27, 2025

Language strings can also be translated since 4e0f8c5

So, anyone translate the language, can also translate the name, example, Greek= Ελληνικά

Like already exists in many apps.

Greek Language Name (Appearance) in Greek.
@VisionR1
Copy link
Contributor Author

VisionR1 commented Feb 27, 2025

@kxob
Done, thanks for reminding me.
Now if the other languages names are translated, the the translators, must put it in language code, which going where.

Some apps use both, example: Ελληνικά (Greek).

@kxob
Copy link
Contributor

kxob commented Feb 27, 2025

@kxob
Done, thanks for reminding me.
Now if the other languages names are translated, the the translators, must put it in language code, which going where.

Some apps use both, example: Ελληνικά (Greek).

Well actually I mean that you can translate language strings in your own language file like values-el/strings.xml but leave the values/strings.xml as-is.

@VisionR1
Copy link
Contributor Author

@kxob
Done, thanks for reminding me.
Now if the other languages names are translated, the the translators, must put it in language code, which going where.
Some apps use both, example: Ελληνικά (Greek).

Well actually I mean that you can translate language strings in your own language file like values-el/strings.xml but leave the values/strings.xml as-is.

Yeah already did this, so change back in the English string, the name Ελληνικά to Greek ?

@kxob
Copy link
Contributor

kxob commented Feb 27, 2025

@kxob
Done, thanks for reminding me.
Now if the other languages names are translated, the the translators, must put it in language code, which going where.
Some apps use both, example: Ελληνικά (Greek).

Well actually I mean that you can translate language strings in your own language file like values-el/strings.xml but leave the values/strings.xml as-is.

Yeah already did this, so change back in the English string, the name Ελληνικά to Greek ?

Yes, make sure that no other languages but only English occur in the original strings.xml. In another word, treat values/strings.xml as values-en/strings.xml.

You can have a glance at https://github.com/kxob/NativeDetector/tree/main/app/src/main/res and see what I do and not do to strings.xml of different language directories.

In summary, you translate these only for when switched to your own language.

@VisionR1
Copy link
Contributor Author

VisionR1 commented Feb 27, 2025

@kxob
Thanks for answer.
I have translate many apps, i don't know why stuck in this lol.
i have try it with change in the original string, and works fine, when go to change language say: Ελληνικά and not Greek, but you're right better not touching the original string.

Add again back the name Greek, with English name.
When select Greek, all Languages appearance in Greek.
@VisionR1
Copy link
Contributor Author

@kxob
So, because i messed up little, i close this PR, after yours #43 merge, i open again a fresh PR.

@VisionR1 VisionR1 closed this Feb 27, 2025
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Language strings can be translated in this file, for example:

    <!-- Language Strings -->
    <string name="en">Αγγλικά</string>
    <string name="ar">Αραβικά</string>
    <string name="de">Γερμανικά</string>
    <string name="el">Ελληνικά</string>
    <string name="es">Ισπανικά</string>
    <string name="id">Ινδονησιακά</string>
    <string name="pl">Πολωνικά</string>
    <string name="pt_br">Πορτογαλικά (Βραζιλία)</string>
    <string name="ru">Ρωσικά</string>
    <string name="sl">Σλοβενικά</string>
    <string name="tr_tr">Τουρκικά (Τουρκία)</string>
    <string name="vi">Βιετναμέζικα</string>
    <string name="zh_cn">Κινέζικα (Απλοποιημένα)</string>
    <string name="zh_tw">Κινέζικα (Παραδοσιακά)</string>

@kxob
Copy link
Contributor

kxob commented Feb 27, 2025

@kxob
So, because i messed up little, i close this PR, after yours #43 merge, i open again a fresh PR.

There's no conflict so it's okay to keep it open.

@VisionR1
Copy link
Contributor Author

VisionR1 commented Feb 28, 2025

@kxob
Yeah, i have already translation this, in the last commit.

So, now remains @reveny to merge this and the rest, i want to see the app in Greek.

@VisionR1 VisionR1 reopened this Feb 28, 2025
<string name="de">Γερμανικά</string>
<string name="el">Ελληνικά</string>
<string name="es">Ισπανικά</string>
<string name="id">Ινδονησιακά</string>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add Japanese into values-el/string.xml

    <string name="ja">Ιαπωνικά</string>

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added. 👍🏻

@VisionR1
Copy link
Contributor Author

VisionR1 commented Mar 1, 2025

@reveny Ready for merge. 👍🏻

@reveny reveny merged commit 73a2fc2 into reveny:main Mar 5, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants