Replace the rest hardcoded strings for new UI#36
Merged
reveny merged 28 commits intoreveny:mainfrom Feb 27, 2025
Merged
Conversation
kxob
changed the title
strings.xmlfor more accurate translations.
…ranslatable And the only one is moved to `strings.xml`
commit 4aac0a3 Author: Beni Fachrudin <[email protected]> Date: Thu Feb 13 20:25:09 2025 +0700 Added several list of {spanish|indonesian} languages (reveny#37) Subsequent to: * 4f95216. * 6251176. * c7e81c7. Change-Id: I6bccd07ce2705a8fb3b2771cdbde83aac842677d Signed-off-by: Neebe3289 <[email protected]>
Contributor
Author
|
@reveny All done, you can merge it now. |
Contributor
|
In English string, i see Detail, is not Details (plural) ? |
Merged
VisionR1
suggested changes
Feb 25, 2025
Contributor
VisionR1
left a comment
VisionR1
left a comment
There was a problem hiding this comment.
I have already translation in Greek (code name "el") according to your PR, to proper appearance Greek, must added.
You have already this PR, so can you add Greek (under German, alphabetically) inside in the "Language.kt" and in English string?
Contributor
|
@reveny |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now all the strings except for those related to check details are localizable.