Fix native backend regression with older MC vers

retrixe · retrixe · commit f99a383ba657 · 2025-02-17T20:38:41.000+05:30
diff --git a/android/app/src/main/java/com/enderchat/modules/connection/ConnectionModule.kt b/android/app/src/main/java/com/enderchat/modules/connection/ConnectionModule.kt
@@ -343,9 +343,9 @@ class ConnectionModule(reactContext: ReactApplicationContext)
         // Remove upstream listeners, stop unnecessary background tasks
     }
 
-    /* private fun println(log: Any?) {
+    private fun println(log: Any?) {
         sendEvent(reactContext = reactApplicationContext, "ecm:log", Arguments.createMap().apply {
             putString("log", log.toString())
         })
-    } */
+    }
 }
diff --git a/src/minecraft/connection/native.ts b/src/minecraft/connection/native.ts
@@ -102,12 +102,13 @@ export class NativeServerConnection extends events.EventEmitter implements Serve
           packet.id === packetIds.CLIENTBOUND_LOGIN_SUCCESS(version) &&
           this.state === ConnectionState.LOGIN
         ) {
-          this.state =
-            version >= protocolMap['1.20.2'] ? ConnectionState.CONFIGURATION : ConnectionState.PLAY
-          this.writePacket(
-            packetIds.SERVERBOUND_LOGIN_ACKNOWLEDGED(version) ?? 0,
-            Buffer.alloc(0),
-          ).catch((err: unknown) => this.emit('error', err))
+          if (version >= protocolMap['1.20.2']) {
+            this.state = ConnectionState.CONFIGURATION
+            this.writePacket(
+              packetIds.SERVERBOUND_LOGIN_ACKNOWLEDGED(version) ?? 0,
+              Buffer.alloc(0),
+            ).catch((err: unknown) => this.emit('error', err))
+          } else this.state = ConnectionState.PLAY
         } else if (
           packet.id === packetIds.CLIENTBOUND_FINISH_CONFIGURATION(version) &&
           this.state === ConnectionState.CONFIGURATION
diff --git a/src/minecraft/packets/ids.ts b/src/minecraft/packets/ids.ts
@@ -23,7 +23,7 @@ const packetIds = {
   SERVERBOUND_LOGIN_START: generateIdFunction([[protocolMap['1.16.4'], 0x00]]),
   SERVERBOUND_ENCRYPTION_RESPONSE: generateIdFunction([[protocolMap['1.16.4'], 0x01]]),
   SERVERBOUND_LOGIN_PLUGIN_RESPONSE: generateIdFunction([[protocolMap['1.16.4'], 0x02]]),
-  SERVERBOUND_LOGIN_ACKNOWLEDGED: generateIdFunction([[protocolMap['1.16.4'], 0x03]]),
+  SERVERBOUND_LOGIN_ACKNOWLEDGED: generateIdFunction([[protocolMap['1.20.2'], 0x03]]),
 
   // ===========================
   // Clientbound (configuration)

Original file line number	Diff line number	Diff line change
`@@ -343,9 +343,9 @@ class ConnectionModule(reactContext: ReactApplicationContext)`
`343`	`343`	`// Remove upstream listeners, stop unnecessary background tasks`
`344`	`344`	`}`
`345`	`345`
`346`		`- /* private fun println(log: Any?) {`
	`346`	`+ private fun println(log: Any?) {`
`347`	`347`	`sendEvent(reactContext = reactApplicationContext, "ecm:log", Arguments.createMap().apply {`
`348`	`348`	`putString("log", log.toString())`
`349`	`349`	`})`
`350`		`- } */`
	`350`	`+ }`
`351`	`351`	`}`