Skip to content

Refactored Converter class #27

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
NotJustAnna merged 5 commits into from
Mar 5, 2020
Merged

Refactored Converter class #27

NotJustAnna merged 5 commits into from
Mar 5, 2020

Conversation

@NotJustAnna
Copy link
Member

@NotJustAnna NotJustAnna commented Mar 5, 2020 •
edited
Loading

Mostly one-to-one rewriting, ended up removing unchecked code in the process.

Changes:

  • Added GroupedResult#toMap, that converts List<GroupedResults<K,V>> to Map<K, List<V>>
  • Binary terms now convert using default Base64 encoder instead of the MIME variant.

@NotJustAnna NotJustAnna merged commit f802597 into develop Mar 5, 2020
@NotJustAnna NotJustAnna deleted the refactor/converter branch March 5, 2020 12:13
@NotJustAnna NotJustAnna added this to the v2.4.2 milestone Mar 22, 2020
@NotJustAnna NotJustAnna mentioned this pull request Mar 22, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

v2.4.2

Development

Successfully merging this pull request may close these issues.

2 participants

@NotJustAnna