Some stdint.h include-what-you-use for alpine/musl #7119
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
context_switching.hpp authentication_error.hpp This addresses a specific alpine (musl) build failure. We add the include to errors.hpp to reduce the probability of such iwyu mishaps in the future.
Another include-what-you-use fix, the last failure seen prior to adding stdint.h to errors.hpp.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This adds some stdint.h includes in response to a user report of compilation failure. The include in errors.hpp is added to generally help reduce the risk of this problem in the future.
It also adds an RDB_NO_BACKTRACE preprocessor conditional around the execinfo.h include.