Skip to content

Conversation

@srh
Copy link
Contributor

@srh srh commented Aug 28, 2022

Description

Applied many changes from @hungte in #688, then applied fixes to get it working on current RethinkDB and FreeBSD 13.

hungte and others added 19 commits August 15, 2022 10:45
This is fine unless we do clone(2) with CLONE_THREAD flag.
For systems using ldconfig with different syntax (ex, FreeBSD or
MacOSX), we need to fallback LD path to defaults.
Tested on FreeBSD 9.1 with following steps:

 # For dependency
 pkg_add -r wget protobuf protobuf-c v8 openjdk7 boost-all gmake
 pkg_add -r bash node npm py-yaml gcc48
 npm install -g less coffee-script handlebars

 # To build with GCC48:
 CXX=gcc48 ./configure --ccache
 # Edit config.mk to add "ALLOW_WARNINGS := 1"

 # To build with system clang 3.1:
 CXX=clang ./configure --ccache
 # You have to install system libc++ by:
 #  cd /usr/src/lib/libc++; sudo make install
 # Then edit config.mk to add "ALLOW_WARNINGS := 1"

 # To build
 gmake
@hungte
Copy link
Contributor

hungte commented Aug 28, 2022

thanks for making the work from #688 up to date.

That was a temporary workaround for a coffee shop firewall.
@srh
Copy link
Contributor Author

srh commented Aug 31, 2022

I checked the unit tests locally and they passed.

@srh srh merged commit a412761 into rethinkdb:v2.4.x Aug 31, 2022
@srh srh deleted the srh/freebsd branch August 31, 2022 15:45
@jphovila
Copy link

jphovila commented Nov 4, 2023

Absolutely wonderful! Thank you for making this happen!

@srh
Copy link
Contributor Author

srh commented Nov 5, 2023

@jphovila I'm glad somebody noticed :-)

@nkosi23
Copy link

nkosi23 commented Jan 31, 2024

@srh @jphovila Is there a FreeBSD port available somewhere?

@srh
Copy link
Contributor Author

srh commented Jan 31, 2024

@nkosi23 As in their package system? I haven't heard of one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants