-
Notifications
You must be signed in to change notification settings - Fork 1.9k
FreeBSD build fixes #7088
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
FreeBSD build fixes #7088
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is fine unless we do clone(2) with CLONE_THREAD flag.
For systems using ldconfig with different syntax (ex, FreeBSD or MacOSX), we need to fallback LD path to defaults.
Tested on FreeBSD 9.1 with following steps: # For dependency pkg_add -r wget protobuf protobuf-c v8 openjdk7 boost-all gmake pkg_add -r bash node npm py-yaml gcc48 npm install -g less coffee-script handlebars # To build with GCC48: CXX=gcc48 ./configure --ccache # Edit config.mk to add "ALLOW_WARNINGS := 1" # To build with system clang 3.1: CXX=clang ./configure --ccache # You have to install system libc++ by: # cd /usr/src/lib/libc++; sudo make install # Then edit config.mk to add "ALLOW_WARNINGS := 1" # To build gmake
Contributor
|
thanks for making the work from #688 up to date. |
That was a temporary workaround for a coffee shop firewall.
Contributor
Author
|
I checked the unit tests locally and they passed. |
|
Absolutely wonderful! Thank you for making this happen! |
Contributor
Author
|
@jphovila I'm glad somebody noticed :-) |
Contributor
Author
|
@nkosi23 As in their package system? I haven't heard of one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Applied many changes from @hungte in #688, then applied fixes to get it working on current RethinkDB and FreeBSD 13.