Merge Windows fixes #7083
Merged
Merge Windows fixes #7083
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since this commit VS2022 with v141 tools and Windows SDK 10.0.19041.0 is required to build RethinkDB on windows. VS2015 no longer has to be installed.
Required for compilation on windows. This commit also removes old gtest source files from this repo, as no-fetch approach is no longer valid.
Original quickjs doesn't support MSVC compiler, hence this change is required for windows build.
- adjust includes - fix metadata_file_t namespacing - fix remove_directory_helper function
Drops the requirement to install cmake explicitly
points out new requirements
Also points to the top commit with an updated README.
Contributor
Author
|
Tested on Windows amd64, Linux amd64, and Linux ARM. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Merges the Windows build fixes, which get the build working on Windows. Almost all of these changes have already been added to v2.4.x-windows in the following PR's: