Skip to content

Windows 10 "support" #7075

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
MrBoombastic wants to merge 8 commits into from
Closed

Windows 10 "support" #7075

MrBoombastic wants to merge 8 commits into from

Conversation

@MrBoombastic
Copy link
Contributor

@MrBoombastic MrBoombastic commented Jun 2, 2022 •
edited
Loading

Description

  • For many years, the first words in console were "Running on Windows 8.1". Now, when you are using Windows 10, RethinkDB will report your OS properly.
  • However, during my testing I noticed, that it is now reporting Windows 10 even if you are using Windows 11. I don't think that it is this code fault - Windows 11 should be recognized as "Unknown". I would rather blame MS. Why? 10 and 11 share same compatibility ID: <supportedOS Id="{8e0f7a12-bfb3-4fe8-b9a5-48fd50a15a9a}"/> and there is even no special function for Windows 11 in Version Helpers.
  • This change will not break any compatibility with any older systems, as said here:

Declaring support for Windows 8.1 or later in your app manifest will not have any effect when running your app on previous operating systems.

  • Windows 10 "support" is done by attaching manifest after building RethinkDB. This changes GetVersion behaviour on modern Windows.
  • This PR is based on PR#7074, so it should be merged first!
  • Attaching binary file just for fun. VirusTotal

Also, thanks @unxcepted for giving me additional, unwanted job and research to do. :D

image

unxcepted and others added 8 commits June 1, 2022 16:06
@unxcepted
windows: use VS 2022 with MSVC v141, fix deps
9611470 
Since this commit VS2022 with v141 tools and Windows SDK 10.0.19041.0  is required to build RethinkDB on windows. VS2015 no longer has to be installed.
@unxcepted
deps: bump gtest to v1.8.1
1eef994 
Required for compilation on windows.
This commit also removes old gtest source files from this repo, as no-fetch approach is no longer valid.
@unxcepted
deps: switch to quickjspp
a4e7ba6 
Original quickjs doesn't support MSVC compiler, hence this change is required for windows build.
@unxcepted
fix windows compilation
6d4ff2c 
- adjust includes
- fix metadata_file_t namespacing
- fix remove_directory_helper function
@unxcepted
windows: use VS cmake
d00424c 
Drops the requirement to install cmake explicitly
@unxcepted
Update WINDOWS.md
290c12c 
points out new requirements
@unxcepted
prevent MSVC tools mismatch
6613dcd
@MrBoombastic
fix: Properly detect Windows 10
f43e106
@srh
Copy link
Contributor

srh commented Jun 13, 2022

This is rebased into v2.4.x-windows as of 3da57f1. Thanks!

@srh srh closed this Jun 13, 2022
This was referenced Aug 8, 2022
Open
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@MrBoombastic @srh @unxcepted