feat: add machine arch and uname to rethinkdb version #7060
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gabor-boros
changed the title
Signed-off-by: Gabor Boros <[email protected]>
gabor-boros
force-pushed
the
gabor/add-machine-to-version
branch
from
0bad090 to
5247cd0
Compare
Member
Author
|
FTR: merging as we discussed with @srh that there are no concerns against this PR |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR resolves #1279 by adding the
uname -rinfo and target architecture to therethinkdb --versionoutput.Example output
Notes
Moved
std::string windows_version_stringandstd::string run_unamebefore its first use for clarity. I can revert that if does not make sense.