refactor: avoid backtrace for user error #7057
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gabor-boros
force-pushed
the
gabor/resolve-4647
branch
from
de7447e to
991aad9
Compare
srh
requested changes
May 2, 2022
Contributor
srh
left a comment
srh
left a comment
There was a problem hiding this comment.
Removing #include <memory> could be considered a defect, and the other changes requested are coding style. Otherwise the changes look correct.
Co-authored-by: Sam Hughes <[email protected]> Signed-off-by: Gabor Boros <[email protected]>
gabor-boros
force-pushed
the
gabor/resolve-4647
branch
from
e645198 to
5cc6c74
Compare
srh
approved these changes
May 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR resolves #4647 by using
fail_due_to_user_erroroverguarantee_errandguarantee_winerrforremove_directory_helper.