build-rpm.sh script updates, CentOS 7 support #7035
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This avoids C11 compilation issues on older platforms, including CentOS 7, and probably, ancient Ubuntus and Debians still in super-extended paid support that we do not support.
This avoids another stdatomic issue, and certainly is not relevant to RethinkDB.
This addresses CentOS 7 linking issues. It is possible the USE_WORKER and CONFIG_ATOMICS changes were only relevant for binaries, not the static library. I have not checked closely.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes build-rpm.sh fetch explicitly which deps it wants to statically link.
Also, makes us only build libquickjs.a, not the entire quickjs "make install" (hence, "make all") target, and disables a couple of exotic QuickJS features: workers and atomics. This gets building for CentOS 7 users working. It also gets Ubuntu Trusty and Debian Jessie package building working.
JS workers and atomics were disabled with the intent to get the build to succeed, but it's also desirable on its own to have that disabled.
Checklist