Apply fixed version of "try to fix memory leak" to v2.4.x #7010
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The preceding commit removes the NOINLINE protection, which allows the compiler (not knowing about on_thread_t) to optimize thread local accesses incorrectly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#6957 would need to be applied to v2.4.x.
Also, it makes the mistake of avoiding the NOINLINE macros. We have thread locals using the peculiar TLS_... macros because our coroutines can switch POSIX threads and basic thread_local usage could cause the compiler to optimize access to the variables such that a second access is assumed to be on the same thread as the first access. An explanation exists in thread_local.hpp.
So now thread_local.hpp is updated to have TLS_with_get_ref, to support noncopyable thread locals and returning them by reference.