Replace v8 with QuickJS #6978
Merged
Replace v8 with QuickJS #6978
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
After a make clean and rebuild, we already see a problem with this PR: |
6 tasks
Contributor
Author
I have some time freed up for this. Reviewing the situation, this is the main (or only?) TODO item. |
Contributor
Author
|
Well, that and addressing this: |
Contributor
Author
|
I have merged this to v2.4.x. I will make a separate issue for Windows support. The reason I merged without Windows support was that Linux ARM builds were hitting v8 problems in #6999. I still have not tested ARM but that is on the to-do. |
1 task
46 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces v8 with QuickJS.
Keeps the Duktape replacement in the git history.
The build system now git clones a vendored repo at https://github.com/srh/rethinkdb-vendored, and we should change that to https://github.com/rethinkdb/rethinkdb-vendored , provided that we do want to make the build system clone a vendored repo for the dependencies this way.
Also, we need to get this working on Windows.