fix: patch for rethinkdb 2.4.1 osx build #6934
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Rui Chen <[email protected]>
Contributor
|
Thank you. It looks like it'll work without updating the vendored boost version. That's a good thing, because the date type is based on the boost library, and I'm not keen on changing how that gets built (though I'm considering that probably we should always vendor it for that reason). Anyway, this patch seems like it'll drop in and build. I'll test it out first and then merge it. |
Contributor
Author
|
Thanks @srh! |
|
any chance of movement on this one @srh ? |
Contributor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
👋 adding a patch for osx builds (see Homebrew/homebrew-core#59643 and Homebrew/homebrew-core#67782)