Allow dash in DB and table names when using '-e' option in rethinkdb-dump #6843
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
@hchac Thank you for your PR 🙏We extracted the python driver to rethinkdb/rethinkdb-python, but not deleted the driver folder from here (yet). If you wouldn't like to do the same change there, I'm happy to do that. |
Member
|
@hchac Closing since the related PR is merged and the change will be release on Tuesday (19th of May) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Hello,
it seems from #5537 that '-' is allowed in DB and table names. However, the
-eoption when usingrethinkdb-dumpbreaks when specifying a DB or table with '-' in its name due to this regex.Opening this pull request to hopefully fix that.