Don't use DNS resolution when finding interface addresses. #6588
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removes use of DNS to find local ip addresses to bind to, except on Windows. Also removes mistaken "Ignore loopback addresses" logic, which happened to get its conditional flipped the wrong way. The flipped "Ignore loopback addresses" logic meant that we would remove all non-loopback addresses that got returned by the DNS lookup. So removing the DNS lookup entirely won't break things. The behavior on Windows never used getifaddrs, it just used DNS lookup. We keep the old behavior on Windows because limited manpower prevents us from implementing the Windows alternative to getifaddrs.
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is a couple of commits on top of #6587, where there's more discussion of what's behind these changes.