JS: Avoid side effects on object passed to r.connect #6575
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(The true author of this is @marshall007 in a comment in PR 6135.)
AtnNn
approved these changes
Apr 1, 2018
Contributor
|
👍 |
Contributor
Author
|
@marshall007 Do you agree to the CLA at https://rethinkdb.com/cla/ ? |
Contributor
|
@srh yea, I've signed the CLA before. Feel free to merge this in. |
Contributor
Author
|
Did you sign the new CLA? |
Contributor
|
I believe so, but I just signed it again just in case. |
Contributor
Author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(The true author of this is @marshall007 in a comment in PR 6135.)
@marshall007 Could you please agree to the CLA for this change? Since you're the author.