Query cache race fix #6564
Closed
Query cache race fix #6564
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Makes the query cache ~ref_t destructor tolerate multiple instances of ~ref_t getting called -- only the first deletion will begin removing the entry. Also makes it not guarantee that state != START -- this is possible if the job gets noticed and then interrupted for a thin slice of time.
Contributor
Author
This was referenced Dec 11, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #6333 and fixes problems I see with #6343.
Basically, it's possible for the state to be START if the job gets user-interrupted very quickly, and I don't know if it's possible for there to be multiple ref_t's to the same entry at a given time, but I assume it is if the client sends the right (or wrong) queries.