Skip to content

Fix potential race condition in query cache #6343

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
AtnNn wants to merge 1 commit into from
Closed

Fix potential race condition in query cache #6343

AtnNn wants to merge 1 commit into from

Conversation

@AtnNn
Copy link
Member

@AtnNn AtnNn commented Apr 29, 2017

terminate_internal modifies the entry->state asynchronously, without holding a lock on the entry.

This might be what caused the guarantee failure in #6333

  • I have read and agreed to the CLA

@AtnNn AtnNn added this to the 2.3.x milestone Apr 29, 2017
@AtnNn AtnNn requested a review from Tryneus April 29, 2017 16:50
@srh
Copy link
Contributor

srh commented May 9, 2017

In principle this looks good to me. But note that in ~ref_t there is a guarantee(entry->state != entry_t::state_t::START) there. That seems like it might now fail, no?

@srh srh modified the milestones: 2.3.6, 2.3.x Jun 22, 2017
@AtnNn AtnNn modified the milestones: 2.3.x, 2.3.6 Jul 11, 2017
@srh srh mentioned this pull request Dec 11, 2017
Closed
1 task
@srh
Copy link
Contributor

srh commented Dec 11, 2017

Fixed by #6564 (which is built off these changes).

@srh srh closed this Dec 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Tryneus Tryneus Awaiting requested review from Tryneus

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

2.3.x

Development

Successfully merging this pull request may close these issues.

2 participants

@AtnNn @srh