Disable broken regex cache #6241
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
LGTM |
AtnNn
added a commit
that referenced
this pull request
Feb 2, 2017
Contributor
|
This doesn't look good to me. How is this "safer"? |
Contributor
|
The changes in 4090d1c are smaller and very straightforward. The regex cache exists for a reason. Throwing this performance regression into 2.3.6 is just broken. |
Member
Author
Contributor
|
Oh I see. OK. LGTM! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #6202 for
2.3.x. #6203 fixes the issue innext.Disabling the cache entirely is the safer option for a point release.