fix: keep multiple libs from catenating versions #6229
Merged
+1
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
<Please fill in the description of your pull request here. Thank you for your contribution!>
From a slack conversation with "@AtnNn"
tennis [1:34 PM]
Hi Guys. I’ve compiled the rethink rpm package on CentOS 7.3 successfully (using this script: https://github.com/rethinkdb/rethinkdb/blob/next/scripts/build-rpm.sh). Everything compiles fine. But when I go to use the rpm to install on exactly the same machine, I get this error:
Any ideas?
atnnn [2:19 PM]
@tennis what is the result of
rpm -qa --queryformat '%{VERSION}' glibc?[2:19]
@tennis Did you build an x86_64 rethinkdb for your i686 system?
tennis [2:21 PM]
@AtnNn I Got it figured out.. There are multiple glibc libs on my machine (i.e. 32 and 64 bit). So the output of
rpm -qa --queryformat '%{VERSION}\n' glibc(note thenewline) is:[2:21]
Without the
\n, the output is:2.172.17atnnn [2:22 PM]
Oh, that's a sneaky bug.
tennis [2:23 PM]
yup. I have to confess I didn’t figure it out on my own. But either way, we know the problem now. I’m happy to issue a pull request against the rethinkdb repo. Which branch should I request a pull into?
atnnn [2:25 PM]
Either
v2.3.x(future 2.3.6) ornext(future 2.4)tennis [2:26 PM]
ok. Thanks