-
Notifications
You must be signed in to change notification settings - Fork 1.9k
Make lru_cache smaller, simpler, and better. #6207
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This bug did not manifest itself before, because of copy elision.
If you have optional<T> x, y; x = *y; guarantee(x);, it is a sign that you did not mean to dereference y. It also means the unchecked deref was supposed to be safe.
Avoids a clang warning about (potentially) misaligned pointers.
Silences a new clang warning on out-of-range truncation.
Naming the file memory.hpp caused some files that #include "memory.hpp" to include the wrong file on Windows, because another file in a subfolder has that name. So we name it memory_utils.hpp.
function.hpp was not included anywhere, and boost::function was only used in some unit test code.
(This fixes the problem where you grep the source code for val_t and get this stuff.
This way we can name the parameter names after we make mailbox_t no longer take a function type parameter.
This is to make contributing more accessible to newbies, since there's not a company anymore.
Apparently these have been failing since write hooks were implemented.
Less interface to maintain, uses unordered_map, and we no longer allocate a new list node and copy the key/value every time we do a lookup.
Contributor
Author
|
I don't know how this history got polluted. But whatever. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6202.
Description
In response to #6203. Note the performance gain -- it doesn't allocate a list node every time you access it.