Skip to content

Conversation

@srh
Copy link
Contributor

@srh srh commented Dec 23, 2016

Fixes #6202.

Description

In response to #6203. Note the performance gain -- it doesn't allocate a list node every time you access it.

srh added 30 commits January 2, 2017 10:15
This bug did not manifest itself before, because of
copy elision.
If you have optional<T> x, y;  x = *y;  guarantee(x);, it is a sign
that you did not mean to dereference y.  It also means the unchecked
deref was supposed to be safe.
Avoids a clang warning about (potentially) misaligned
pointers.
Silences a new clang warning on out-of-range truncation.
Naming the file memory.hpp caused some files that #include "memory.hpp" to
include the wrong file on Windows, because another file in a subfolder
has that name.  So we name it memory_utils.hpp.
function.hpp was not included anywhere, and boost::function was
only used in some unit test code.
(This fixes the problem where you grep the source code for val_t
and get this stuff.
This way we can name the parameter names after we make mailbox_t
no longer take a function type parameter.
srh and others added 6 commits January 2, 2017 10:15
This is to make contributing more accessible to newbies, since there's
not a company anymore.
Apparently these have been failing since write hooks were
implemented.
Less interface to maintain, uses unordered_map, and we no longer
allocate a new list node and copy the key/value every time we do a
lookup.
@srh
Copy link
Contributor Author

srh commented Jan 2, 2017

I don't know how this history got polluted. But whatever.

@srh srh closed this Jan 2, 2017
@AtnNn AtnNn added this to the invalid milestone Jan 29, 2017
@srh srh mentioned this pull request Dec 10, 2017
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants