Avoid side effects on 'hostOrCallback' #6135
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's better to clone 'hostOrCallback' to avoid side effects. If you run r.connect more than one time with the same config object, it(config) gets mutated in case 'username' is set instead of 'user'. Then, the second time you run r.connect, with the same config object, the driver will complain that you can't use both 'username' and 'user' at the same time. Object.assign on 'hostOrCallback' will fix this issue.
Contributor
|
There's a bug here, yes. Object.assign is only supported by Node.js 4 and up. Might that be a problem? Anybody? |
Contributor
|
@srh Node v0.12.x and earlier (aka anything before v4.x) are well past their LTS lifecycle, so I have no objection to relying on newer runtimes. |
Contributor
|
A problem with this PR is that r.connect can take a string, and this breaks that behavior. |
Contributor
|
Yea we'll need to do something like: if typeof hostOrCallback is 'function'
callback = hostOrCallback
else if typeof hostOrCallback is 'string'
host = hostOrCallback
else
host = Object.assign {}, hostOrCallback |
Author
|
How about: connect = varar 0, 2, () ->
args = Array.prototype.slice.call arguments,0,2
{ host, callback } = ( (hostOrCallback,callback)->
if typeof hostOrCallback == 'function'
host: {}, callback: hostOrCallback
else if typeof hostOrCallback == 'string'
host: hostOrCallback, callback: callback
else
host: Object.assign({}, hostOrCallback), callback: callback
).apply(undefined, args)
# connect Promise can happily mutate host
# ....
|
Contributor
|
Closing for #6575 which is just @marshall007's implementation. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's better to clone 'hostOrCallback' to avoid side effects.
If you run r.connect more than one time with the same config object,
it gets mutated in case 'username' is set instead of 'user'.
Then, the second time you run r.connect, with the same config object,
the driver will complain that you can't use both 'username' and 'user'
at the same time.
Object.assign on 'hostOrCallback' will fix this issue.