Skip to content

Incorrect call signature for conn.close() in net_asyncio #5795

@skolsuper

Description

@skolsuper

I am using rethinkdb Python driver version 2.3.0.post3 with asyncio and am getting the below exception thrown from net_asyncio whenever there is any problem connecting to the database.

It seems like the call signature for conn.close has changed but the Exception handlers here have not been updated to match.

TypeError: close() missing 2 required positional arguments: 'noreply_wait' and 'token'
  ...
  File "resync/connection.py", line 31, in get_conn
    conn = await r.connect(**self._config_dict)
  File "rethinkdb/asyncio_net/net_asyncio.py", line 283, in reconnect
    return (yield from self._instance.connect(timeout))
  File "rethinkdb/asyncio_net/net_asyncio.py", line 175, in connect
    yield self.close()

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions