Skip to content

sftp ReadDir: add path to return error messages (gh-1323) - #1398

Merged
fd0 merged 1 commit into
restic:masterfrom
armhold:sftp-readdir
Oct 29, 2017
Merged

sftp ReadDir: add path to return error messages (gh-1323)#1398
fd0 merged 1 commit into
restic:masterfrom
armhold:sftp-readdir

Conversation

@armhold

@armhold armhold commented Oct 28, 2017 •
edited by fd0
Loading

Copy link
Copy Markdown
Contributor

also fix missing "Close" string in debug log fmt

Closes #1323

@armhold
sftp ReadDir: add path to return error messages (resticgh-1323)
d8938e2 
fix missing "Close" string in debug log fmt
@codecov-io

codecov-io commented Oct 28, 2017 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #1398 into master will decrease coverage by 5.5%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1398      +/-   ##
==========================================
- Coverage   51.15%   45.64%   -5.51%     
==========================================
  Files         136      136              
  Lines       13600    13605       +5     
==========================================
- Hits         6957     6210     -747     
- Misses       5784     6591     +807     
+ Partials      859      804      -55
Impacted Files Coverage Δ
internal/backend/sftp/sftp.go 58.72% <100%> (+0.6%) ⬆️
internal/backend/b2/b2.go 0% <0%> (-80.08%) ⬇️
internal/backend/azure/azure.go 0% <0%> (-75.35%) ⬇️
internal/backend/swift/swift.go 0% <0%> (-73.9%) ⬇️
internal/backend/gs/gs.go 0% <0%> (-68.96%) ⬇️
internal/backend/swift/config.go 34.37% <0%> (-56.25%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 53a554c...d8938e2. Read the comment docs.

@fd0 fd0 mentioned this pull request Oct 29, 2017
Closed
fd0
fd0 approved these changes Oct 29, 2017
View reviewed changes

@fd0 fd0 left a comment •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, great catch!

FYI: Include the GitHub issue ID like this #1323, then it will be automatically linked in the UI (and there'll be a backlink in the issue): #1323

For GitHub, it is best practice to mention the issue ID in the text of the pull request, so there will be nice links back and forth between the issue and the PR.

I've added the text Closes #1323 to the PR message, so the issue will be closed automatically when the PR is merged.

@fd0
fd0 merged commit d8938e2 into restic:master Oct 29, 2017
fd0 added a commit that referenced this pull request Oct 29, 2017
@fd0
Merge pull request #1398 from armhold/sftp-readdir
ca3cade 
sftp ReadDir: add path to return error messages (gh-1323)
@armhold

armhold commented Oct 29, 2017

Copy link
Copy Markdown
Contributor Author

Sorry about the misplaced issue ID. I thought including "gh-1323" in both the commit text as well as the PR "subject" line would cover it, but I guess not. :-)

@fd0

fd0 commented Oct 29, 2017

Copy link
Copy Markdown
Member

No worries, I was surprised that GitHub even linked the gh-1323 text. :)

@armhold

armhold commented Oct 29, 2017

Copy link
Copy Markdown
Contributor Author

Yeah "gh-FOO" is a standard shortcut for github commits and they get automatically linked. The "#foo" one was news to me. :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fd0 fd0 fd0 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

SFTP Permission denied do not say what path failed, and sometimes error silently

3 participants

@armhold @codecov-io @fd0