[RESTEASY-2772] changed exception type and adjusted unit tests

rsearls · asoldano · commit 1f773f3c1b45 · 2020-12-02T22:18:46.000+01:00
diff --git a/providers/multipart/src/main/java/org/jboss/resteasy/plugins/providers/multipart/MultipartReader.java b/providers/multipart/src/main/java/org/jboss/resteasy/plugins/providers/multipart/MultipartReader.java
@@ -15,6 +15,7 @@
 import java.io.InputStream;
 import java.lang.annotation.Annotation;
 import java.lang.reflect.Type;
+import javax.ws.rs.BadRequestException;
 
 /**
  * @author <a href="mailto:bill@burkecentral.com">Bill Burke</a>
@@ -35,7 +36,7 @@ public boolean isReadable(Class<?> type, Type genericType, Annotation[] annotati
    public MultipartInput readFrom(Class<MultipartInput> type, Type genericType, Annotation[] annotations, MediaType mediaType, MultivaluedMap<String, String> httpHeaders, InputStream entityStream) throws IOException, WebApplicationException
    {
       String boundary = mediaType.getParameters().get("boundary");
-      if (boundary == null) throw new IOException(Messages.MESSAGES.unableToGetBoundary());
+      if (boundary == null) throw new BadRequestException(Messages.MESSAGES.unableToGetBoundary());
       MultipartInputImpl input = new MultipartInputImpl(mediaType, workers);
       /*
       StringWriter writer = new StringWriter();
diff --git a/resteasy-jaxrs/src/main/java/org/jboss/resteasy/plugins/delegates/MediaTypeHeaderDelegate.java b/resteasy-jaxrs/src/main/java/org/jboss/resteasy/plugins/delegates/MediaTypeHeaderDelegate.java
@@ -7,6 +7,7 @@
 import javax.ws.rs.ext.RuntimeDelegate;
 
 import java.util.HashMap;
+import javax.ws.rs.BadRequestException;
 
 /**
  * @author <a href="mailto:bill@burkecentral.com">Bill Burke</a>
@@ -113,7 +114,7 @@ public static MediaType parse(String type)
          }
          if (!MediaType.MEDIA_TYPE_WILDCARD.equals(major))
          {
-            throw new IllegalArgumentException(Messages.MESSAGES.failureParsingMediaType(type));
+            throw new BadRequestException(Messages.MESSAGES.failureParsingMediaType(type));
          }
          subtype = MediaType.MEDIA_TYPE_WILDCARD;
       }
@@ -131,11 +132,11 @@ public static MediaType parse(String type)
       }
       if (major.length() < 1 || subtype.length() < 1)
       {
-         throw new IllegalArgumentException(Messages.MESSAGES.failureParsingMediaType(type));
+         throw new BadRequestException(Messages.MESSAGES.failureParsingMediaType(type));
       }
       if (!isValid(major) || !isValid(subtype))
       {
-         throw new IllegalArgumentException(Messages.MESSAGES.failureParsingMediaType(type));
+         throw new BadRequestException(Messages.MESSAGES.failureParsingMediaType(type));
       }
       String params = null;
       if (paramIndex > -1) params = type.substring(paramIndex + 1);
diff --git a/testsuite/unit-tests/src/test/java/org/jboss/resteasy/test/client/ClientBuilderTest.java b/testsuite/unit-tests/src/test/java/org/jboss/resteasy/test/client/ClientBuilderTest.java
@@ -16,6 +16,7 @@
 import javax.ws.rs.core.Response;
 import javax.ws.rs.ext.ContextResolver;
 import javax.ws.rs.ext.RuntimeDelegate;
+import javax.ws.rs.BadRequestException;
 
 import static org.jboss.resteasy.test.TestPortProvider.generateURL;
 
@@ -32,7 +33,7 @@ public class ClientBuilderTest {
     * @tpPassCrit IllegalArgumentException is raised
     * @tpSince RESTEasy 3.0.16
     */
-   @Test(expected = IllegalArgumentException.class)
+   @Test(expected = BadRequestException.class)
    public void entityStringThrowsExceptionWhenUnparsableTest() throws Exception {
       Entity.entity("entity", "\\//\\");
       Assert.fail();
diff --git a/testsuite/unit-tests/src/test/java/org/jboss/resteasy/test/mediatype/MediaTypeHeaderTest.java b/testsuite/unit-tests/src/test/java/org/jboss/resteasy/test/mediatype/MediaTypeHeaderTest.java
@@ -2,10 +2,11 @@
 
 import org.jboss.resteasy.plugins.delegates.MediaTypeHeaderDelegate;
 import org.junit.Test;
+import javax.ws.rs.BadRequestException;
 
 public class MediaTypeHeaderTest {
 
-   @Test(expected = IllegalArgumentException.class)
+   @Test(expected = BadRequestException.class)
    public void testNewLineInHeaderValueIsRejected() {
       MediaTypeHeaderDelegate delegate = new MediaTypeHeaderDelegate();
 

Original file line number	Diff line number	Diff line change
`@@ -7,6 +7,7 @@`
`7`	`7`	`import javax.ws.rs.ext.RuntimeDelegate;`
`8`	`8`
`9`	`9`	`import java.util.HashMap;`
	`10`	`+import javax.ws.rs.BadRequestException;`
`10`	`11`
`11`	`12`	`/**`
`12`	`13`	`* @author <a href="mailto:[email protected]">Bill Burke</a>`
`@@ -113,7 +114,7 @@ public static MediaType parse(String type)`
`113`	`114`	`}`
`114`	`115`	`if (!MediaType.MEDIA_TYPE_WILDCARD.equals(major))`
`115`	`116`	`{`
`116`		`- throw new IllegalArgumentException(Messages.MESSAGES.failureParsingMediaType(type));`
	`117`	`+ throw new BadRequestException(Messages.MESSAGES.failureParsingMediaType(type));`
`117`	`118`	`}`
`118`	`119`	`subtype = MediaType.MEDIA_TYPE_WILDCARD;`
`119`	`120`	`}`
`@@ -131,11 +132,11 @@ public static MediaType parse(String type)`
`131`	`132`	`}`
`132`	`133`	`if (major.length() < 1 \|\| subtype.length() < 1)`
`133`	`134`	`{`
`134`		`- throw new IllegalArgumentException(Messages.MESSAGES.failureParsingMediaType(type));`
	`135`	`+ throw new BadRequestException(Messages.MESSAGES.failureParsingMediaType(type));`
`135`	`136`	`}`
`136`	`137`	`if (!isValid(major) \|\| !isValid(subtype))`
`137`	`138`	`{`
`138`		`- throw new IllegalArgumentException(Messages.MESSAGES.failureParsingMediaType(type));`
	`139`	`+ throw new BadRequestException(Messages.MESSAGES.failureParsingMediaType(type));`
`139`	`140`	`}`
`140`	`141`	`String params = null;`
`141`	`142`	`if (paramIndex > -1) params = type.substring(paramIndex + 1);`