Skip to content

Download the template from the examples repo#24

Merged
slinkydeveloper merged 2 commits intomainfrom
issues/22
Apr 23, 2024
Merged

Download the template from the examples repo#24
slinkydeveloper merged 2 commits intomainfrom
issues/22

Conversation

@slinkydeveloper
Copy link
Contributor

@slinkydeveloper slinkydeveloper commented Apr 23, 2024 •
edited
Loading

Fix #22

Also updated eslint to use 9.x, bumped minimum node version (for fetch)

gvdongen
gvdongen approved these changes Apr 23, 2024
View reviewed changes
Copy link
Contributor

@gvdongen gvdongen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me but we also need to update the comments in the template itself: https://github.com/restatedev/examples/blob/dev_0.9/templates/typescript/src/app.ts

Or make sure they don't have code in them because they are constantly outdated....

@gvdongen
Copy link
Contributor

gvdongen commented Apr 23, 2024

Looks good to me but we also need to update the comments in the template itself: https://github.com/restatedev/examples/blob/dev_0.9/templates/typescript/src/app.ts

Or make sure they don't have code in them because they are constantly outdated....

It should just refer to the quickstart actually. Should I pick this up?

@slinkydeveloper @gvdongen
Apply suggestions from code review
4a796fb 
Co-authored-by: Giselle van Dongen <[email protected]>
@slinkydeveloper
Copy link
Contributor Author

slinkydeveloper commented Apr 23, 2024 •
edited
Loading

It should just refer to the quickstart actually. Should I pick this up?

That would be great. Perhaps the same should be done for java and kotlin

@slinkydeveloper slinkydeveloper merged commit e181e30 into main Apr 23, 2024
@slinkydeveloper slinkydeveloper deleted the issues/22 branch April 23, 2024 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gvdongen gvdongen gvdongen approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Let the template generator download the template from the examples repo

2 participants

@slinkydeveloper @gvdongen