Add simulated failure handler and/or improve error message #239
Closed
kpwebb wants to merge 2 commits intorestatedev:mainfrom
Closed
Add simulated failure handler and/or improve error message #239kpwebb wants to merge 2 commits intorestatedev:mainfrom
kpwebb wants to merge 2 commits intorestatedev:mainfrom
Conversation
Collaborator
|
Hi @kpwebb, Thank you for your contribution! I think this is a super fair remark and I can fully see where you are coming from.
I'll have a look at some nice ways to take your feedback into account tomorrow. Thanks again |
Author
|
Thanks for investigating, and the FAILING=true env is a great idea! |
Collaborator
|
Hi @kpwebb Thanks for proposing this improvement! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi, just sharing this as potential improvement for the hello-world example. I was deploying on a multi-machine setup and missed that the example had a random failure by design and thought it was a problem with the networking set up. Might be good to either include [SIMULATED] in the error logs, or offer up a handler that explicitly calls out the failure mode.