Syntax highlighting: support more themes. #406
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of semantic token `type` use `support.type` from the grammar. This is what TypeScript does too. For keywords from the grammar, use `storage.type` instead of `keyword`. Again this is taken from what TS does. This change is a no-op on the themes considered so far. But improves theme `Solarized Light`. There seems to be no way to fix `Mariana Pro (Warm)`, which completely disables semantic highlighting. Looks like TS has the same problem there.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of semantic token
typeusesupport.type.primitivefrom the grammar. This is what TypeScript does too.For keywords from the grammar, use
storage.typeinstead ofkeyword. Again this is taken from what TS does.This change is a no-op on the themes considered so far. But improves theme
Solarized LightandOne Dark Pro.Remove
Mariana Pro (Warm)from the list of recommended themes, as it seems to disable semantic highlighting entirely.Looks like TS has the same problem there.