Skip to content

Fix tooltips being dragged along in graph view#8573

Merged
grtlr merged 1 commit intomainfrom
grtlr/fix-hover-graph
Jan 3, 2025
Merged

Fix tooltips being dragged along in graph view#8573
grtlr merged 1 commit intomainfrom
grtlr/fix-hover-graph

Conversation

@grtlr
Copy link
Copy Markdown
Member

@grtlr grtlr commented Jan 3, 2025

Related

What

This fixes the problem by tying to tooltip position to the node position instead of the the pointer, with the nice side-effect that tooltips can now be interacted with in the graph view.

There is some weirdness with tooltips opening for the tooltips, but we should probably tackle that separately.

image

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jan 3, 2025

Web viewer built successfully. If applicable, you should also test it:

  • I have tested the web viewer
Result Commit Link Manifest
9e499b4 https://rerun.io/viewer/pr/8573 +nightly +main

Note: This comment is updated whenever you push a commit.

Copy link
Copy Markdown
Member

@Wumpf Wumpf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

@grtlr grtlr merged commit 80bd667 into main Jan 3, 2025
@grtlr grtlr deleted the grtlr/fix-hover-graph branch January 3, 2025 11:31
@grtlr grtlr added this to the Next patch release milestone Jan 20, 2025
@Wumpf Wumpf removed this from the Next patch release milestone Feb 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

include in changelog ui concerns graphical user interface

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Tooltip moves with the cursor during hovering in graph view

2 participants