Skip to content

Add support for NumPy arrays to the arrow serializer for string datatypes#7689

Merged
abey79 merged 8 commits intomainfrom
antoine/utf8-numpy
Oct 14, 2024
Merged

Add support for NumPy arrays to the arrow serializer for string datatypes#7689
abey79 merged 8 commits intomainfrom
antoine/utf8-numpy

Conversation

@abey79
Copy link
Copy Markdown
Member

@abey79 abey79 commented Oct 11, 2024 •
edited by github-actions bot
Loading

What

This adds support for Numpy array for batches of Utf8 datatypes. For example, this facilitates logging a TextBatch when using Pandas dataframe:

rr.send_columns(
    "/entity/path",
    times=[rr.TimeSequenceColumn("frame_nr", df["frame_nr"])],
    components=[
        rr.components.TextBatch(np.where(df["mouth_open"], "OPEN", "CLOSE")),
    ],
)

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I have tested the web demo (if applicable):
  • The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG
  • If applicable, add a new check to the release checklist!
  • If have noted any breaking changes to the log API in CHANGELOG.md and the migration guide

To run all checks from main, comment on the PR with @rerun-bot full-check.

@Wumpf Wumpf self-requested a review October 11, 2024 09:29
@abey79 abey79 marked this pull request as draft October 11, 2024 09:30
Wumpf
Wumpf requested changes Oct 11, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@Wumpf Wumpf left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unit test plz!

also this could be fairly easy part of codegen? Something seems to be wrong with codegen here

@abey79 abey79 changed the title Add support for NumPy arrays to the Utf8 datatype arrow serializer Add support for NumPy arrays to the arrow serializer for string datatypes Oct 11, 2024
@abey79 abey79 force-pushed the antoine/utf8-numpy branch from 9d7a0d8 to bb3f99f Compare October 11, 2024 13:04
@abey79 abey79 marked this pull request as ready for review October 11, 2024 13:04
@abey79 abey79 force-pushed the antoine/utf8-numpy branch from bb3f99f to 487e557 Compare October 11, 2024 13:15
@abey79 abey79 requested a review from Wumpf October 11, 2024 13:15
Wumpf
Wumpf approved these changes Oct 14, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@Wumpf Wumpf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

annotation only change now huh? But very nice to solve this once and for all via codegen :)

@abey79 abey79 merged commit 07fb9e7 into main Oct 14, 2024
@abey79 abey79 deleted the antoine/utf8-numpy branch October 14, 2024 08:24
@Wumpf Wumpf mentioned this pull request Oct 16, 2024
Merged
6 tasks
emilk added a commit that referenced this pull request Nov 26, 2025
@emilk @lucasmerlin
Update to egui 0.33.2 (#11889)
a8afd23 
Changes in snapshot images should be pixel-alignment improvements thanks
to
* emilk/egui#7710


---

## egui changelog
### ⭐ Added
* Add `Plugin::on_widget_under_pointer` to support widget inspector
[#7652](emilk/egui#7652) by
[@juancampa](https://github.com/juancampa)
* Add `Response::total_drag_delta` and `PointerState::total_drag_delta`
[#7708](emilk/egui#7708) by
[@emilk](https://github.com/emilk)

### 🔧 Changed
* Improve accessibility and testability of `ComboBox`
[#7658](emilk/egui#7658) by
[@lucasmerlin](https://github.com/lucasmerlin)

### 🐛 Fixed
* Fix `profiling::scope` compile error when profiling using `tracing`
backend [#7646](emilk/egui#7646) by
[@PPakalns](https://github.com/PPakalns)
* Fix edge cases in "smart aiming" in sliders
[#7680](emilk/egui#7680) by
[@emilk](https://github.com/emilk)
* Hide scroll bars when dragging other things
[#7689](emilk/egui#7689) by
[@emilk](https://github.com/emilk)
* Prevent widgets sometimes appearing to move relative to each other
[#7710](emilk/egui#7710) by
[@emilk](https://github.com/emilk)
* Fix `ui.response().interact(Sense::click())` being flakey
[#7713](emilk/egui#7713) by
[@lucasmerlin](https://github.com/lucasmerlin)

## eframe changelog
* Fix jittering during window resize on MacOS for WGPU/Metal
[#7641](emilk/egui#7641) by
[@aspcartman](https://github.com/aspcartman)
* Make sure `native_pixels_per_point` is set during app creation
[#7683](emilk/egui#7683) by
[@emilk](https://github.com/emilk)

---------

Co-authored-by: Lucas Meurer <[email protected]>
Co-authored-by: lucasmerlin <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Wumpf Wumpf Wumpf approved these changes

Assignees

No one assigned

Labels

include in changelog sdk-python Python logging API

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@abey79 @Wumpf @teh-cmc