Empty column tracker and new dataframe APIs on top#7677
Merged
Conversation
teh-cmc
added
🔍 re_query
teh-cmc
force-pushed
the
cmc/store_empty_writes
branch
3 times, most recently
from
b3cde2b to
11f9156
Compare
teh-cmc
force-pushed
the
cmc/store_empty_writes
branch
from
11f9156 to
f5b5d3c
Compare
teh-cmc
force-pushed
the
cmc/store_empty_writes
branch
from
f5b5d3c to
7ba19c7
Compare
6 tasks
jleibs
approved these changes
Oct 11, 2024
Comment on lines
+194
to
+204
|
|
||
| /// Whether this column represents an indicator component. | ||
| pub is_indicator: bool, | ||
|
|
||
| /// Whether this column represents a [`Clear`]-related components. | ||
| /// | ||
| /// [`Clear`]: re_types_core::archetypes::Clear | ||
| pub is_tombstone: bool, | ||
|
|
||
| /// Whether this column contains either no data or only contains null and/or empty values (`[]`). | ||
| pub is_semantically_empty: bool, |
Contributor
There was a problem hiding this comment.
Should we just expose ColumnMetadata here directly?
Contributor
Author
There was a problem hiding this comment.
Eeeh, as this is the heart of the API, I'd prefer to keep it flat, simple to inspect and simple to build by hand.
teh-cmc
added a commit
that referenced
this pull request
Oct 11, 2024
emilk
added
exclude from changelog
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before:
After:
Of course with static data this still looks pretty weird in many cases, such as shown in this screenshot,
But that's a job for the upcoming #7668.
Checklist
mainbuild: rerun.io/viewernightlybuild: rerun.io/viewerCHANGELOG.mdand the migration guideTo run all checks from
main, comment on the PR with@rerun-bot full-check.