Skip to content

Introduce new script that validates the signatures match between the .pyi file and the bridge#7646

Merged
jleibs merged 10 commits intomainfrom
jleibs/check_bridge_signatures
Oct 9, 2024
Merged

Introduce new script that validates the signatures match between the .pyi file and the bridge#7646
jleibs merged 10 commits intomainfrom
jleibs/check_bridge_signatures

Conversation

@jleibs
Copy link
Copy Markdown
Contributor

@jleibs jleibs commented Oct 8, 2024 •
edited by github-actions bot
Loading

What

Detected several issues:

➜  pixi run check-py-signatures
✨ Pixi task (check-py-signatures in py): python scripts/ci/check_python_signatures.py
IndexColumnSelector.__new__(…) signature mismatch:
    Stub: (cls, index)
    Runtime: (*args, **kwargs)
ComponentColumnSelector.__new__(…) signature mismatch:
    Stub: (cls, entity_path, component_type)
    Runtime: (*args, **kwargs)
Recording.view(…) signature mismatch:
    Stub: (self, /, index, contents)
    Runtime: (self, /, *, index, contents)
load_recording(…) signature mismatch:
  Stub: (filename)
  Runtime: (path_to_rrd)
load_archive(…) signature mismatch:
  Stub: (filename)
  Runtime: (path_to_rrd)

Example CI failure:
image

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I have tested the web demo (if applicable):
  • The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG
  • If applicable, add a new check to the release checklist!
  • If have noted any breaking changes to the log API in CHANGELOG.md and the migration guide

To run all checks from main, comment on the PR with @rerun-bot full-check.

@jleibs jleibs added sdk-python Python logging API exclude from changelog PRs with this won't show up in CHANGELOG.md labels Oct 8, 2024
@jleibs jleibs marked this pull request as ready for review October 8, 2024 22:07
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Oct 8, 2024 •
edited
Loading

Deployed docs

Commit Link
b814b3c https://landing-q3riqv4vf-rerun.vercel.app/docs

@teh-cmc teh-cmc self-requested a review October 9, 2024 06:57
teh-cmc
teh-cmc approved these changes Oct 9, 2024
View reviewed changes
abey79
abey79 approved these changes Oct 9, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@abey79 abey79 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Extremely based

scripts/ci/check_python_signatures.py
from pathlib import Path
from typing import Any

import parso
Copy link
Copy Markdown
Member

@abey79 abey79 Oct 9, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this be added to the pixi.toml?

Copy link
Copy Markdown
Contributor Author

@jleibs jleibs Oct 9, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was already in the environment, but good call. I'll make it explicit.

@jleibs jleibs merged commit a98d534 into main Oct 9, 2024
@jleibs jleibs deleted the jleibs/check_bridge_signatures branch October 9, 2024 16:06
emilk added a commit that referenced this pull request Nov 26, 2025
@emilk @lucasmerlin
Update to egui 0.33.2 (#11889)
a8afd23 
Changes in snapshot images should be pixel-alignment improvements thanks
to
* emilk/egui#7710


---

## egui changelog
### ⭐ Added
* Add `Plugin::on_widget_under_pointer` to support widget inspector
[#7652](emilk/egui#7652) by
[@juancampa](https://github.com/juancampa)
* Add `Response::total_drag_delta` and `PointerState::total_drag_delta`
[#7708](emilk/egui#7708) by
[@emilk](https://github.com/emilk)

### 🔧 Changed
* Improve accessibility and testability of `ComboBox`
[#7658](emilk/egui#7658) by
[@lucasmerlin](https://github.com/lucasmerlin)

### 🐛 Fixed
* Fix `profiling::scope` compile error when profiling using `tracing`
backend [#7646](emilk/egui#7646) by
[@PPakalns](https://github.com/PPakalns)
* Fix edge cases in "smart aiming" in sliders
[#7680](emilk/egui#7680) by
[@emilk](https://github.com/emilk)
* Hide scroll bars when dragging other things
[#7689](emilk/egui#7689) by
[@emilk](https://github.com/emilk)
* Prevent widgets sometimes appearing to move relative to each other
[#7710](emilk/egui#7710) by
[@emilk](https://github.com/emilk)
* Fix `ui.response().interact(Sense::click())` being flakey
[#7713](emilk/egui#7713) by
[@lucasmerlin](https://github.com/lucasmerlin)

## eframe changelog
* Fix jittering during window resize on MacOS for WGPU/Metal
[#7641](emilk/egui#7641) by
[@aspcartman](https://github.com/aspcartman)
* Make sure `native_pixels_per_point` is set during app creation
[#7683](emilk/egui#7683) by
[@emilk](https://github.com/emilk)

---------

Co-authored-by: Lucas Meurer <[email protected]>
Co-authored-by: lucasmerlin <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@abey79 abey79 abey79 approved these changes

+1 more reviewer

@teh-cmc teh-cmc teh-cmc approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

exclude from changelog PRs with this won't show up in CHANGELOG.md sdk-python Python logging API

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Validate .pyi is self consistent with our bindings

3 participants

@jleibs @teh-cmc @abey79