Skip to content

Rename TimeColumn -> IndexColumn and assorted fixes#7636

Merged
jleibs merged 4 commits intomainfrom
jleibs/dataframe_api_fixes
Oct 8, 2024
Merged

Rename TimeColumn -> IndexColumn and assorted fixes#7636
jleibs merged 4 commits intomainfrom
jleibs/dataframe_api_fixes

Conversation

@jleibs
Copy link
Copy Markdown
Contributor

@jleibs jleibs commented Oct 8, 2024

What

  • Rename had not been completed
  • Discovered column names aren't being assigned properly while testing

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I have tested the web demo (if applicable):
  • The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG
  • If applicable, add a new check to the release checklist!
  • If have noted any breaking changes to the log API in CHANGELOG.md and the migration guide

To run all checks from main, comment on the PR with @rerun-bot full-check.

@jleibs jleibs requested a review from abey79 October 8, 2024 14:38
@jleibs jleibs added feat-dataframe-api Everything related to the dataframe API include in changelog labels Oct 8, 2024
@jleibs jleibs marked this pull request as ready for review October 8, 2024 14:38
@jleibs jleibs added sdk-python Python logging API exclude from changelog PRs with this won't show up in CHANGELOG.md and removed include in changelog labels Oct 8, 2024
@jleibs jleibs merged commit 5852681 into main Oct 8, 2024
@jleibs jleibs deleted the jleibs/dataframe_api_fixes branch October 8, 2024 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

exclude from changelog PRs with this won't show up in CHANGELOG.md feat-dataframe-api Everything related to the dataframe API sdk-python Python logging API

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants