Skip to content

Add test for UI wakeup#7422

Merged
emilk merged 10 commits intomainfrom
emilk/test_ui_wakeup
Sep 18, 2024
Merged

Add test for UI wakeup#7422
emilk merged 10 commits intomainfrom
emilk/test_ui_wakeup

Conversation

@emilk
Copy link
Copy Markdown
Member

@emilk emilk commented Sep 16, 2024 •
edited by github-actions bot
Loading

What

Issues found

How to test

Test setup - build the viewer

  • pixi run rerun-build
  • pixi run rerun-build-web

Test matrix

  • Run cargo r -p test_ui_wakeup and test:
    • That the viewer wakes up in the background when it's alt-tabbed
    • That the viewer wakes up when minimized (it should log "Received a message from…")
  • Run cargo r -p test_ui_wakeup -- --serve and test:
    • The viewer wakes up when browser is alt-tabbed away
    • Switch to a different browser tab, send a few messages, switch back. The messages should be there
      (this is not a conclusive test, as the messages might have been received on tab select)

Tested

Web

Linux

  • ✅X11 alt-tabbed
  • ✅ X11 minimized
  • ✅ Wayland alt-tabbed
  • ❌ Wayland minimized (Hyprland placed on non-visible workspace)
  • ✅ X-Wayland alt-tabbed
  • ✅ X-Wayland minimized (Hyprland placed on non-visible workspace)

Mac

  • ✅ Native alt-tabbed
  • ✅ Native minimized

Windows

  • ✅ Native alt-tabbed
  • ✅ Native minimized

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I have tested the web demo (if applicable):
  • The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG
  • If applicable, add a new check to the release checklist!
  • If have noted any breaking changes to the log API in CHANGELOG.md and the migration guide

To run all checks from main, comment on the PR with @rerun-bot full-check.

@emilk emilk added 🔨 testing testing and benchmarks 🧑‍💻 dev experience developer experience (excluding CI) exclude from changelog PRs with this won't show up in CHANGELOG.md labels Sep 16, 2024
@emilk emilk force-pushed the emilk/test_ui_wakeup branch from c642583 to a04ce8d Compare September 16, 2024 14:30
@emilk emilk force-pushed the emilk/test_ui_wakeup branch from a04ce8d to faa0e9b Compare September 16, 2024 14:45
@emilk emilk mentioned this pull request Sep 16, 2024
Merged
6 tasks
@emilk emilk marked this pull request as ready for review September 16, 2024 14:53
@emilk emilk mentioned this pull request Sep 16, 2024
Open
emilk added a commit that referenced this pull request Sep 16, 2024
@emilk
Bug fix: always show latest data in follow-mode (#7425)
17fb079 
### What
* Found while testing #7422

Always show the latest data in follow-mode, by advancing the time at the
start of the frame rather than at the end of it.

### Checklist
* [x] I have read and agree to [Contributor
Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and
the [Code of
Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md)
* [x] I've included a screenshot or gif (if applicable)
* [x] I have tested the web demo (if applicable):
* Using examples from latest `main` build:
[rerun.io/viewer](https://rerun.io/viewer/pr/7425?manifest_url=https://app.rerun.io/version/main/examples_manifest.json)
* Using full set of examples from `nightly` build:
[rerun.io/viewer](https://rerun.io/viewer/pr/7425?manifest_url=https://app.rerun.io/version/nightly/examples_manifest.json)
* [x] The PR title and labels are set such as to maximize their
usefulness for the next release's CHANGELOG
* [x] If applicable, add a new check to the [release
checklist](https://github.com/rerun-io/rerun/blob/main/tests/python/release_checklist)!
* [x] If have noted any breaking changes to the log API in
`CHANGELOG.md` and the migration guide

- [PR Build Summary](https://build.rerun.io/pr/7425)
- [Recent benchmark results](https://build.rerun.io/graphs/crates.html)
- [Wasm size tracking](https://build.rerun.io/graphs/sizes.html)

To run all checks from `main`, comment on the PR with `@rerun-bot
full-check`.
abey79
abey79 approved these changes Sep 18, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@abey79 abey79 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems very useful!

@emilk emilk merged commit 6121840 into main Sep 18, 2024
@emilk emilk deleted the emilk/test_ui_wakeup branch September 18, 2024 08:48
@emilk emilk mentioned this pull request Sep 20, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@abey79 abey79 abey79 approved these changes

Assignees

No one assigned

Labels

🧑‍💻 dev experience developer experience (excluding CI) exclude from changelog PRs with this won't show up in CHANGELOG.md 🔨 testing testing and benchmarks

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@emilk @abey79