Chunk store browser #7226
Chunk store browser #7226
Conversation
- case insensitive filtering - timeline columns with time range - better component schema + copy on click - transport chunk metadata
# Conflicts: # Cargo.lock # Cargo.toml # crates/viewer/re_viewer/Cargo.toml
abey79
added
ui
|
Nice! Small nit: |
Yeah the reasoning is that the actual column content is narrow (just a number), so it's annoying to have a wide column header. Let's see if we can figure out something better with @gavrelina |
|
teh-cmc
left a comment
teh-cmc
left a comment
There was a problem hiding this comment.
That's amazing 🙇
UPDATE: I found the cause, see code comments. My recommendation is simply to add a TODO, maybe open an issue. The root of the issue that the chunk will be displated with comfyterm, which will use the width of the parent terminal as a hint.
When you click the copy-as-text button, I'm not quite sure how the implementation decides what width should each column be? The current value is annoyingly small (a RowId doesn't even fit on a single line):
The fact that I'm wasting all this vertical space at the top even when I've uncollapsed everything is annoying:
The timestamp ranges in the chunk list could use an indication of the time spanned, e.g.
#0..=#1 255 (1 255 ticks) | #103..=#2 613 (2510 ticks) | 2024-08-26 12:38:33.536540Z..=2024-08-26 12:38:33.740418Z (0.203878 seconds)`
they see me browsin', they hatin'
| use re_chunk_store::external::re_chunk::external::arrow2::array::Utf8Array; | ||
| use re_viewer_context::UiLayout; | ||
|
|
||
| //TODO(ab): this is copied/modified from `re_data_ui`. Consider unifying them? |
There was a problem hiding this comment.
Also we really need to setup a registry for lossless text representations of arrow payloads based on semantic types.
E.g. I want rerun.components.Color to display as 0xFF88AAFF, not the unintelligible integer it prints today.
And that's not specific to this view, it's everywhere we represent arrow as just lossless text (including terminal dumps).
There was a problem hiding this comment.
Agreed.
Alternatively, I would eventually like to have a toggle to apply the entire re_data_ui machinery for display. That could be useful eg. for interpreting enums (can those eventually be fully arrow?). That feature would have to be behind a cargo flag, such that re_chunk_store_ui can remain independent from the rerun viewer, should we want to make it its own binary.
…) don't cross pollinate with each other
…esn't mess with column sizing. To be addressed with: emilk/egui#5015
Co-authored-by: Clement Rey <[email protected]>
Co-authored-by: Clement Rey <[email protected]>
Co-authored-by: Clement Rey <[email protected]>
Yes, that's was an unwanted consequence of the fancy sort arrow ui. I've reverted to a less nice UI that doesn't cause the issue. This will be further addressed later with: Edit: I didn't read your original comment properly and answered to something else 🤦🏻. Yeah I agree this is not ideal. Not sure what's the immediate step should be here. I suggest we let it simmer for a bit to figure out what's the best way (e.g. would a top toggle table vs. metadata tree be ok or is it useful see both the metadata and the table at once?) |
|
New issue for the width of the copied text: |
…th and range + duration otherwise
Remember to always review changes to And if you have merge conflicts in |
What
This PR introduce a new, low-level chunk store browser crate
re_chunk_store_uiwith the following features:The feature is available from the rerun menu and the
ctrl-shift-Dshortcut.Note: it would be very easy to drop the current
re_viewer_contextdependency and make a stand-alone chunk store viewer binary that only depends onre_uiand the lower-level store/type crates.Checklist
mainbuild: rerun.io/viewernightlybuild: rerun.io/viewerCHANGELOG.mdand the migration guideTo run all checks from
main, comment on the PR with@rerun-bot full-check.