Skip to content

Use new .clamp_to_range(false) to make sure drag value inputs are not changed by looking at them #6677

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
emilk merged 2 commits into from
Jun 28, 2024
Merged

Use new .clamp_to_range(false) to make sure drag value inputs are not changed by looking at them #6677

emilk merged 2 commits into from
Jun 28, 2024

Conversation

@Wumpf
Copy link
Member

@Wumpf Wumpf commented Jun 28, 2024 •
edited by emilk
Loading

What

Screen.Recording.2024-06-28.at.11.52.22.mov

Undraft condition:

  • land egui pr and point to master branch here instead

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I have tested the web demo (if applicable):
  • The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG
  • If applicable, add a new check to the release checklist!

To run all checks from main, comment on the PR with @rerun-bot full-check.

@Wumpf Wumpf added ui concerns graphical user interface exclude from changelog PRs with this won't show up in CHANGELOG.md labels Jun 28, 2024
@Wumpf Wumpf changed the title Use new .only_clamp_on_input(true) to make sure drag value inputs are not changed by looking at them Use new .clamp_to_range(false) to make sure drag value inputs are not changed by looking at them Jun 28, 2024
@Wumpf Wumpf force-pushed the andreas/only-apply-change-on-input branch 3 times, most recently from 42adf5f to 03170ac Compare June 28, 2024 14:12
emilk
emilk reviewed Jun 28, 2024
View reviewed changes
@Wumpf Wumpf force-pushed the andreas/only-apply-change-on-input branch from 03170ac to 890d79b Compare June 28, 2024 14:14
@Wumpf Wumpf marked this pull request as ready for review June 28, 2024 14:18
@emilk emilk merged commit 59276f9 into main Jun 28, 2024
@emilk emilk deleted the andreas/only-apply-change-on-input branch June 28, 2024 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@emilk emilk emilk approved these changes

Assignees

No one assigned

Labels

exclude from changelog PRs with this won't show up in CHANGELOG.md ui concerns graphical user interface

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add DragValue::only_clamp_on_input to egui and use it for all drag values in edit ui

3 participants

@Wumpf @emilk