Skip to content

Pin mimalloc to 0.1.37#5874

Merged
teh-cmc merged 3 commits intomainfrom
cmc/mimalloc_revert
Apr 9, 2024
Merged

Pin mimalloc to 0.1.37#5874
teh-cmc merged 3 commits intomainfrom
cmc/mimalloc_revert

Conversation

@teh-cmc
Copy link
Copy Markdown
Contributor

@teh-cmc teh-cmc commented Apr 9, 2024

mimalloc starts leaking OS pages starting with 0.1.38.

We don't know the full story yet, but for now we want to focus on shipping 0.15 and then we can investigate all of that calmly.

TODO:

  • (Linux) cherry pick on 0.15 and check that it fixes the leak
  • (MacOS) cherry pick on 0.15 and check that it fixes the leak

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I have tested the web demo (if applicable):
  • The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG
  • If applicable, add a new check to the release checklist!

@teh-cmc teh-cmc added 🪳 bug Something isn't working 📉 performance Optimization, memory use, etc dependencies concerning crates, pip packages etc exclude from changelog PRs with this won't show up in CHANGELOG.md labels Apr 9, 2024
@teh-cmc teh-cmc force-pushed the cmc/mimalloc_revert branch from 9b6cccc to 61dc0b2 Compare April 9, 2024 13:53
@teh-cmc teh-cmc merged commit c97ee89 into main Apr 9, 2024
@teh-cmc teh-cmc deleted the cmc/mimalloc_revert branch April 9, 2024 13:55
teh-cmc added a commit that referenced this pull request Apr 9, 2024
`mimalloc` starts leaking OS pages starting with `0.1.38`.

We don't know the full story yet, but for now we want to focus on
shipping 0.15 and then we can investigate all of that calmly.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🪳 bug Something isn't working dependencies concerning crates, pip packages etc exclude from changelog PRs with this won't show up in CHANGELOG.md 📉 performance Optimization, memory use, etc

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants