SDK DataLoaders 8: customizable (external) loaders for C++
#5361
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
teh-cmc
added
do-not-merge
8 tasks
teh-cmc
added a commit
that referenced
this pull request
Mar 1, 2024
Introduces the new `DataLoaderSettings` business to Python and update examples accordingly (`external_data_loader` & `log_file`). ```bash python examples/python/external_data_loader/main.py --recording-id this-one --entity-path-prefix a/b/c --time sim_time=1000 --time wall_time=1709204046 --sequence sim_frame=42 examples/python/dna/main.py | rerun - ```  Checks: - [x] external loader ran manually (`python loader | rerun`) - [x] external loader via rerun (`rerun xxx.py`) - [x] log_file with external loader (`log_file xxx.py`) --- Part of series of PR to expose configurable `DataLoader`s to our SDKs: - #5327 - #5328 - #5330 - #5337 - #5351 - #5355 - #5361
teh-cmc
force-pushed
the
cmc/sdk_dataloader_7_cpp_settings
branch
3 times, most recently
from
f77e8b4 to
cc02362
Compare
teh-cmc
changed the title
DataLoaders 7: customizable (external) loaders for C++DataLoaders 8: customizable (external) loaders for C++
This was referenced Mar 4, 2024
teh-cmc
force-pushed
the
cmc/sdk_dataloader_7_cpp_settings
branch
from
cc02362 to
76d84d8
Compare
teh-cmc
changed the base branch from
main
to
cmc/sdk_dataloader_7_stateful_log_file
teh-cmc
force-pushed
the
cmc/sdk_dataloader_7_cpp_settings
branch
2 times, most recently
from
7ae4317 to
dcdfca3
Compare
5 tasks
Wumpf
approved these changes
Mar 4, 2024
Member
Wumpf
left a comment
Wumpf
left a comment
There was a problem hiding this comment.
this looks pretty nice for a c++ pr 😁
|
|
||
| // Inform the Rerun Viewer that we do not support that kind of file. | ||
| if (!is_file || is_cpp_file) { | ||
| if (!is_file || !is_cpp_file) { |
Member
There was a problem hiding this comment.
oops, how did that go through before
teh-cmc
added a commit
that referenced
this pull request
Mar 4, 2024
This makes the `log_file` APIs behave more like the standard `log` APIs; i.e. they inherit the state of their associated `RecordingStream` (app_id, rec_id, timepoint, etc...). Also inherit the application ID while we're at it. Makes the API much nicer to use _and_ much more consistent with the rest. Checks: - [x] external loader ran manually (`python loader | rerun`) - [x] external loader via rerun (`rerun xxx.py`) - [x] log_file with external loader (`log_file xxx.py`) - [x] external loader ran manually (`loader | rerun`) - [x] external loader via rerun (`rerun xxx.rs`) - [x] log_file with external loader (`log_file xxx.rs`) --- Part of series of PR to expose configurable `DataLoader`s to our SDKs: - #5327 - #5328 - #5330 - #5337 - #5351 - #5355 - #5379 - #5361 - #5388 --------- Co-authored-by: Andreas Reich <[email protected]>
teh-cmc
force-pushed
the
cmc/sdk_dataloader_7_cpp_settings
branch
from
d6c346c to
25b281a
Compare
teh-cmc
added a commit
that referenced
this pull request
Mar 6, 2024
I guess that's good enough 🤷. I don't know, my brain has been completely friend by C++ non-sense all day. This includes a fix to make sure that a viewer that was spawned from the python SDK is still allowed to spawn dataloaders implemented in python (`RERUN_APP_ONLY` shenaniganeries). - Fixes #4526 --- Part of series of PR to expose configurable `DataLoader`s to our SDKs: - #5327 - #5328 - #5330 - #5337 - #5351 - #5355 - #5379 - #5361 - #5388
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduces the new
DataLoaderSettingsbusiness to C++ and update examples accordingly (external_data_loader&log_file)../build/debug/examples/cpp/log_file/example_log_file --recording-id this-one --entity-path-prefix a/b/c --time sim_time=1000 --time wall_time=1709204046 --sequence sim_frame=42 rerun_cpp/tests/main.cpp | rerun -Checks:
loader.exe | rerun)rerun xxx.cpp)log_file xxx.cpp)Part of series of PR to expose configurable
DataLoaders to our SDKs:DataLoaders 1: barebones Rust support #5327DataLoaders 2: barebones Python support #5328DataLoaders 3: barebones C and C++ support #5330DataLoaders 4: working around shutdown brittleness #5337DataLoaders 5: customizable (external) loaders for Rust #5351DataLoaders 6: customizable (external) loaders for Python #5355DataLoaders 7: stateful file logging #5379DataLoaders 8: customizable (external) loaders for C++ #5361DataLoaders 9: polish, docs, etc #5388Checklist
mainbuild: app.rerun.ionightlybuild: app.rerun.io