Skip to content

Primary cache: do not err on PrimaryNotFound #4892

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Wumpf merged 1 commit into from
Jan 24, 2024
Merged

Primary cache: do not err on PrimaryNotFound #4892

Wumpf merged 1 commit into from
Jan 24, 2024

Conversation

@teh-cmc
Copy link
Member

@teh-cmc teh-cmc commented Jan 23, 2024 •
edited by github-actions bot
Loading

Ignore PrimaryNotFound errors on the cached entity_iterator path, the same way the vanilla path does.

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I have tested the web demo (if applicable):
  • The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG

@teh-cmc teh-cmc added 🪳 bug Something isn't working 🔍 re_query affects re_query itself do-not-merge Do not merge this PR exclude from changelog PRs with this won't show up in CHANGELOG.md labels Jan 23, 2024
@github-actions
Copy link

github-actions bot commented Jan 23, 2024

Size changes

Name cmc/primcache_19_statification 4892/merge Change
JS 139.41 kiB 111.52 kiB -20.01%

@teh-cmc teh-cmc force-pushed the cmc/primcache_19_statification branch from dd80167 to 5b4e1d4 Compare January 23, 2024 16:51
Base automatically changed from cmc/primcache_19_statification to main January 23, 2024 17:01
@teh-cmc teh-cmc force-pushed the cmc/primcache_weird_error branch from a020239 to bebd894 Compare January 23, 2024 17:14
@teh-cmc teh-cmc removed the do-not-merge Do not merge this PR label Jan 24, 2024
@Wumpf Wumpf self-requested a review January 24, 2024 09:41
@Wumpf Wumpf merged commit 2bc6431 into main Jan 24, 2024
@Wumpf Wumpf deleted the cmc/primcache_weird_error branch January 24, 2024 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Wumpf Wumpf Wumpf approved these changes

Assignees

No one assigned

Labels

🪳 bug Something isn't working exclude from changelog PRs with this won't show up in CHANGELOG.md 🔍 re_query affects re_query itself

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Primary cache: fix error log sometimes when scrolling out of bounds

3 participants

@teh-cmc @Wumpf