Allow Blueprint types to be full Archetype/Components within a scoped namespace #4477
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jleibs
changed the title
jleibs
added
the
exclude from changelog
jleibs
force-pushed
the
jleibs/blueprint_scoping
branch
from
f2a2bdc to
94b6d8b
Compare
jleibs
force-pushed
the
jleibs/blueprint_scoping
branch
from
94b6d8b to
d8d2c66
Compare
teh-cmc
approved these changes
Dec 12, 2023
Member
teh-cmc
left a comment
teh-cmc
left a comment
There was a problem hiding this comment.
One oddity in the C++ output but other than that I think this looks as expected. 🥵
Member
There was a problem hiding this comment.
rerun/blueprint/blueprint, something went wrong... is this some orphaned thing?
Member
Author
There was a problem hiding this comment.
Ahh, yes, that was one of the things that got fixed later in the stack but I failed to commit the removal. Thanks for catching.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Blueprint code will benefit from being able to leverage the same Archetype / Component patterns as our other datatypes.
Rather than treating Blueprint as an alternative ObjectKind this now uses a
blueprintscope for the given blueprint types. This had some obnoxious fan-out to clean up all of the C++ header / include / namespace / python import stuff.Probably best reviewed commit by commit.
Checklist