C++: Allow creating Image/Tensor/DepthImage/SegmentationImage directly from shape & pointer #4345
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
and improve docs a bit on the way
Wumpf
added
enhancement
jleibs
approved these changes
Nov 27, 2023
Member
jleibs
left a comment
jleibs
left a comment
There was a problem hiding this comment.
Nice. Only nit is it would be nice having an example somewhere (other than the tests) showing the pointer-based constructor mechanism.
Member
Author
|
We decided to let the opencv one do that instead of writing an adapter there. But I agree it would be nice to have this in the regular examples as well 🤔 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Also a bunch of doc polish in related areas on the way.
Collection now has an
emptymethod.Checklist