Skip to content

Move side-panels margins inside of their ScrollAreas #4340

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
abey79 merged 2 commits into from
Nov 27, 2023
Merged

Move side-panels margins inside of their ScrollAreas #4340

abey79 merged 2 commits into from
Nov 27, 2023

Conversation

@abey79
Copy link
Member

@abey79 abey79 commented Nov 27, 2023 •
edited
Loading

What

This PR changes the way inner margins and ScrollAreas are nested to avoid some visual issues.

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I have tested demo.rerun.io (if applicable)
  • The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG

@abey79 abey79 added 🪳 bug Something isn't working ui concerns graphical user interface exclude from changelog PRs with this won't show up in CHANGELOG.md labels Nov 27, 2023
@abey79 abey79 mentioned this pull request Nov 27, 2023
Merged
4 tasks
emilk
emilk approved these changes Nov 27, 2023
View reviewed changes
crates/re_viewer/src/ui/selection_panel.rs
// Set the clip rectangle to the panel for the benefit of nested, "full span" widgets
// like large collapsing headers. Here, no need to extend `ui.max_rect()` as the
// enclosing frame doesn't have inner margins.
ui.set_clip_rect(ui.max_rect());
Copy link
Member

@emilk emilk Nov 27, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this clip-rect call still needed?

Copy link
Member Author

@abey79 abey79 Nov 27, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. I believe the ScrollArea sets the clip rect only if it actually cuts into content. Even then, it extends it by clip_rect_margin, leading to glitches such as this:

image

@abey79 abey79 merged commit fd4f9b1 into main Nov 27, 2023
@abey79 abey79 deleted the antoine/fix-panels-scrollarea-layout branch November 27, 2023 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@emilk emilk emilk approved these changes

Assignees

No one assigned

Labels

🪳 bug Something isn't working exclude from changelog PRs with this won't show up in CHANGELOG.md ui concerns graphical user interface

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Fix Blueprint Tree scrollbar spacing

3 participants

@abey79 @emilk