Update egui and wgpu #4111
Merged
Update egui and wgpu #4111
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wumpf
added
🔺 re_renderer
Member
Author
|
(don't merge tag for depending on an egui PR commit) |
jleibs
approved these changes
Nov 1, 2023
Member
jleibs
left a comment
jleibs
left a comment
There was a problem hiding this comment.
Changes all look straightforward
Wumpf
added
blocked
Member
|
I suggest we wait with this until we are ready for the next egui release, containing the new multi-viewport PR and probably a winit update: https://github.com/emilk/egui/milestone/2 |
Merged
4 tasks
Member
|
Testing:
Test:
|
Member
|
Ok, everything is updated and ready |
emilk
removed
blocked
Member
|
Breaks window resizing and frequently crashes on wgpu errors on X11 (XWayland) and Wayland |
Member
|
@teh-cmc Does emilk/egui#3643 fix your problems? i.e. patching |
Member
yep, fixed |
Member
|
Clement says it is good now. I'm gonna give WebGPU a whirl, then merge it. |
Member
|
WebGPU works well in Arc (chromium) on my Mac |
emilk
pushed a commit
that referenced
this pull request
Dec 1, 2023
…d guides (#4300) ### What egui 0.24 will fix the bug where coping from Safari was impossible: - emilk/egui#3513 This PR removes the related warnings in the in-app Getting Started guides. - May be blocked by lampsitter/egui_commonmark#21?? - Blocked by #4111 - Fixes #4292 ### Checklist * [x] I have read and agree to [Contributor Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and the [Code of Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md) * [x] I've included a screenshot or gif (if applicable) * [x] I have tested [demo.rerun.io](https://demo.rerun.io/pr/4300) (if applicable) * [x] The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG - [PR Build Summary](https://build.rerun.io/pr/4300) - [Docs preview](https://rerun.io/preview/0a0e58f6c169798c01d1932ecec3fb51cfe6360e/docs) <!--DOCS-PREVIEW--> - [Examples preview](https://rerun.io/preview/0a0e58f6c169798c01d1932ecec3fb51cfe6360e/examples) <!--EXAMPLES-PREVIEW--> - [Recent benchmark results](https://build.rerun.io/graphs/crates.html) - [Wasm size tracking](https://build.rerun.io/graphs/sizes.html)
abey79
added a commit
that referenced
this pull request
Dec 1, 2023
…in timeseries space views (#4270) ### What * Fixes #4246 * Depends on emilk/egui#3586 * Blocked on #4111  ### Checklist * [x] I have read and agree to [Contributor Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and the [Code of Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md) * [x] I've included a screenshot or gif (if applicable) * [x] I have tested [demo.rerun.io](https://demo.rerun.io/pr/4270) (if applicable) * [x] The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG - [PR Build Summary](https://build.rerun.io/pr/4270) - [Docs preview](https://rerun.io/preview/2706326572e06cf2623136a62fee75d75b490fdd/docs) <!--DOCS-PREVIEW--> - [Examples preview](https://rerun.io/preview/2706326572e06cf2623136a62fee75d75b490fdd/examples) <!--EXAMPLES-PREVIEW--> - [Recent benchmark results](https://build.rerun.io/graphs/crates.html) - [Wasm size tracking](https://build.rerun.io/graphs/sizes.html) --------- Co-authored-by: Andreas Reich <[email protected]> Co-authored-by: Emil Ernerfeldt <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Test Matrix
Make sure to click through a few examples to cover at least points, lines and meshes. (Arkit is a good one!)
Test window-related stuff on Linux:
Mac
Linux
Windows
Merge egui PR
Checklist