Fix quadratic slowdown when ingesting data with uniform time #3088
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This optimizes the case of inserting already-sorted data (common case) and fixes quadratic runtime when inserting a lot of data with the exact same time stamp.
emilk
added
🪳 bug
teh-cmc
approved these changes
Aug 23, 2023
jleibs
pushed a commit
that referenced
this pull request
Aug 31, 2023
### What * Closes #3086 * Closes #433 This should also overall just speed up data insertion for the common case of already-sorted data ### Checklist * [x] I have read and agree to [Contributor Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and the [Code of Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md) * [x] I've included a screenshot or gif (if applicable) * [x] I have tested [demo.rerun.io](https://demo.rerun.io/pr/3088) (if applicable) - [PR Build Summary](https://build.rerun.io/pr/3088) - [Docs preview](https://rerun.io/preview/e5adb1aa580de2274b4eca9f6c5de38ae503b521/docs) <!--DOCS-PREVIEW--> - [Examples preview](https://rerun.io/preview/e5adb1aa580de2274b4eca9f6c5de38ae503b521/examples) <!--EXAMPLES-PREVIEW--><!--EXAMPLES-PREVIEW--> - [Recent benchmark results](https://ref.rerun.io/dev/bench/) - [Wasm size tracking](https://ref.rerun.io/dev/sizes/)
jleibs
pushed a commit
that referenced
this pull request
Aug 31, 2023
### What * Closes #3086 * Closes #433 This should also overall just speed up data insertion for the common case of already-sorted data ### Checklist * [x] I have read and agree to [Contributor Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and the [Code of Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md) * [x] I've included a screenshot or gif (if applicable) * [x] I have tested [demo.rerun.io](https://demo.rerun.io/pr/3088) (if applicable) - [PR Build Summary](https://build.rerun.io/pr/3088) - [Docs preview](https://rerun.io/preview/e5adb1aa580de2274b4eca9f6c5de38ae503b521/docs) <!--DOCS-PREVIEW--> - [Examples preview](https://rerun.io/preview/e5adb1aa580de2274b4eca9f6c5de38ae503b521/examples) <!--EXAMPLES-PREVIEW--><!--EXAMPLES-PREVIEW--> - [Recent benchmark results](https://ref.rerun.io/dev/bench/) - [Wasm size tracking](https://ref.rerun.io/dev/sizes/)
jleibs
pushed a commit
that referenced
this pull request
Aug 31, 2023
### What * Closes #3086 * Closes #433 This should also overall just speed up data insertion for the common case of already-sorted data ### Checklist * [x] I have read and agree to [Contributor Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and the [Code of Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md) * [x] I've included a screenshot or gif (if applicable) * [x] I have tested [demo.rerun.io](https://demo.rerun.io/pr/3088) (if applicable) - [PR Build Summary](https://build.rerun.io/pr/3088) - [Docs preview](https://rerun.io/preview/e5adb1aa580de2274b4eca9f6c5de38ae503b521/docs) <!--DOCS-PREVIEW--> - [Examples preview](https://rerun.io/preview/e5adb1aa580de2274b4eca9f6c5de38ae503b521/examples) <!--EXAMPLES-PREVIEW--><!--EXAMPLES-PREVIEW--> - [Recent benchmark results](https://ref.rerun.io/dev/bench/) - [Wasm size tracking](https://ref.rerun.io/dev/sizes/)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
This should also overall just speed up data insertion for the common case of already-sorted data
Checklist