C++ basic Archetype & Component logging #2874
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
teh-cmc
approved these changes
Jul 31, 2023
3 tasks
Wumpf
added a commit
that referenced
this pull request
Aug 2, 2023
…t APIs & introduce C++ SDK tests (#2890) * Part of #2516 (SDK! Not codegen! :)) * Next in the cpp series after #2874 ### What Adds a test dependency to the [Catch2](https://github.com/catchorg/Catch2/) testing framework in order to start testing all the new RecordingStream features added here. C++ tests can be conveniently run via `./rerun_cpp/build_and_run_tests.sh` now! For quick api overview start with the `rerun.h` and `recording_stream.h` headers. Fixes a range of compiler warnings as a consequence of improving some of the CMake setup, more to do there! Adds lots more documentation to RecordingStream as well. Next steps: * Add C++ to ci (linting, running this test suite) * Add roundtrip tests * Add codegen custom code injection * Improve API usability in varous places, including * #2873 * add other tests * serialize unions * serialize datatypes nested in unions, structs and lists * more testing & roundtripping ### Checklist * [x] I have read and agree to [Contributor Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and the [Code of Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md) * [x] I've included a screenshot or gif (if applicable) * [x] I have tested [demo.rerun.io](https://demo.rerun.io/pr/2890) (if applicable) - [PR Build Summary](https://build.rerun.io/pr/2890) - [Docs preview](https://rerun.io/preview/pr%3Aandreas%2Fcpp-api%2Fbetter-recording-stream/docs) - [Examples preview](https://rerun.io/preview/pr%3Aandreas%2Fcpp-api%2Fbetter-recording-stream/examples)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Introduces APIs for component and archetype logging as well as the necessary methods in codegen to do so. A very basic example is included in
main.cpp.Largely unrelated to the rest:
to_arrow_datatypeconstructs/allocates the datatype lazily exactly once (using C++'s crazy localstaticvariable guarantees)Commit by commit review possible.
Next steps:
Checklist